You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by d0k1 <gi...@git.apache.org> on 2016/01/27 21:58:10 UTC
[GitHub] jmeter pull request: More JSyntaxTextArea settings
GitHub user d0k1 opened a pull request:
https://github.com/apache/jmeter/pull/91
More JSyntaxTextArea settings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d0k1/jmeter trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 84a4e473fabc54f3c62063207ab20513ffd5bdf7
Author: dOkI <de...@gmail.com>
Date: 2016-01-27T20:51:11Z
More JSyntaxTextArea settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-181077864
@d0k1 don't forget to ping me on github after the update of your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-186879979
@d0k1 Thanks for your improvement patch. Committed on jmeter repo, sorry for long delay for commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by d0k1 <gi...@git.apache.org>.
Github user d0k1 commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-181558787
@milamberspace Thanks for pointing me a bug. I've fixed it, squashed all commits into one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by d0k1 <gi...@git.apache.org>.
Github user d0k1 commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-176916072
Hi! thanks for comments.
I'll make a bugzilla issue by myself, next time.
Could you tell me what should I do next?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: More JSyntaxTextArea settings
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-175880747
Thanks for your PR.
Some comments:
* That would be better to use Constants (final public static) for properties strings inside .java files (like jsyntaxtextarea.font, etc.) Particularly with the property key is use into several java files.
* The change inside the file JMeterUtils.java seems not necessary?
* Probably the best place inside the jmeter.properties for this new properties is the section Look&feel (start at line ~110)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/91#discussion_r52122001
--- Diff: src/core/org/apache/jmeter/gui/util/JSyntaxTextArea.java ---
@@ -90,6 +95,9 @@ public JSyntaxTextArea(int rows, int cols, boolean disableUndo) {
super.setLineWrap(LINE_WRAP);
super.setWrapStyleWord(WRAP_STYLE_WORD);
this.disableUndo = disableUndo;
+ if(USER_FONT_FAMILY!=null) {
+ setFont(new Font(USER_FONT_FAMILY, Font.PLAIN, USER_FONT_SIZE));
--- End diff --
@d0k1 your PR have a bug: when the jsyntaxtextarea.font.size property is defined and jsyntaxtextarea.font.family is *not* defined, the size is not change on the textarea.
Probably, you must define the default value to "JSyntaxTextArea.getDefaultFont().getName()" the USER_FONT_FAMILY constants, and remove this if condition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-177597892
@d0k1: You can modify your PR to include the comments above directly on your local branch, commit, squash your commits into one commit, push with --force option to update your PR on Github.
After ping me (on github or bugzilla) to allow me to include your code in JMeter source repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-176471792
Hi,
Thanks for PR.
I created https://bz.apache.org/bugzilla/show_bug.cgi?id=58933 for follow up.
@milamberspace I let you handle this.
@d0k1 , if you intend to submit more PRs, it is good to create a bugzilla for it.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---