You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by yi...@apache.org on 2024/05/15 09:08:14 UTC
(hudi) 05/32: [HUDI-6386] Enable testArchivalWithMultiWriters back as they are passing (#9085)
This is an automated email from the ASF dual-hosted git repository.
yihua pushed a commit to branch branch-0.x
in repository https://gitbox.apache.org/repos/asf/hudi.git
commit 0a556cb3dcddfaec03bf0985454b4058eef00f03
Author: Sivabalan Narayanan <n....@gmail.com>
AuthorDate: Tue Apr 23 21:19:50 2024 -0700
[HUDI-6386] Enable testArchivalWithMultiWriters back as they are passing (#9085)
Co-authored-by: Balaji Varadarajan <vb...@apache.org>
---
.../org/apache/hudi/io/TestHoodieTimelineArchiver.java | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
index 034bcc8788a..1edef971097 100644
--- a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
+++ b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
@@ -65,7 +65,6 @@ import org.apache.hudi.testutils.HoodieSparkClientTestHarness;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
@@ -689,17 +688,9 @@ public class TestHoodieTimelineArchiver extends HoodieSparkClientTestHarness {
assertThrows(HoodieException.class, () -> metaClient.getArchivedTimeline().reload());
}
- @Disabled("HUDI-6841")
- public void testArchivalWithMultiWritersMDTDisabled() throws Exception {
- testArchivalWithMultiWriters(false);
- }
-
- @Disabled("HUDI-6386")
- public void testArchivalWithMultiWriters() throws Exception {
- testArchivalWithMultiWriters(true);
- }
-
- private void testArchivalWithMultiWriters(boolean enableMetadata) throws Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ public void testArchivalWithMultiWriters(boolean enableMetadata) throws Exception {
HoodieWriteConfig writeConfig = initTestTableAndGetWriteConfig(enableMetadata, 4, 5, 5, 2,
HoodieTableType.COPY_ON_WRITE, false, 10, 209715200,
HoodieFailedWritesCleaningPolicy.LAZY, WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL);