You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Andrew Grieve <ag...@chromium.org> on 2014/02/28 21:37:35 UTC
[Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Note that since we can't re-upload to NPM with the same versions, I've
bumped the version since my first attempt.
If you'd like to verify the files on dist/, you can now clone the repo via:
./cordova-coho/coho repo-clone -r dist/dev
And check the hashes & signature with:
./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
There's no logic there to check the actual contents of the zip yet though
(if someone feels like adding this, please do!)
Please review and vote on the release of cordova@3.4.0-0.1.2 plugman@0.20.1.
Release issue: https://issues.apache.org/jira/browse/CB-6115
Both cordova and plugman have been uploaded to npm with the "rc" tag:
npm install -g cordova@rc
npm install -g plugman@rc
They have also been published to dist:
https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
The packages were published from their corresponding git tags:
plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
Upon a successful vote, I will tag the releases as "latest" on NPM and post
the corresponding blog post.
Voting will go on for 48 hours.
Re: [Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Posted by Bryan Higgins <br...@bryanhiggins.net>.
I found the following regression while testing this release against BB10.
https://issues.apache.org/jira/browse/CB-6140
I'm not familiar enough with the changes in plugman to have an opinion on
whether this outweighs the benefits introduced, so I won't vote either way.
Otherwise project creation, adding/removing plugins and build/run all
worked well.
On Fri, Feb 28, 2014 at 4:05 PM, Ian Clelland <ic...@chromium.org>wrote:
> +1
>
> Checked signatures and hashes. Checked diffs (not too crude a tool) against
> the corresponding tags in the repos.
> Installed both plugman and CLI; both appear to be working correctly,
> building projects, adding and removing plugins, building and deploying to
> Android devices.
>
>
> On Fri, Feb 28, 2014 at 4:00 PM, Joe Schaefer <joe_schaefer@yahoo.com
> >wrote:
>
> > If diff is a little too crude for this purpose I encourage you to
> > take a look at
> >
> >
> >
> https://svn.apache.org/repos/private/committers/tools/releases/compare_dirs.pl
> >
> > The way you'd use it is to unzip the two archive files into separate
> paths
> > and invoke this script on those paths. It takes a list of filenames to
> > skip as arguments, but those could probably be scripted away into a
> wrapper
> > call around it.
> >
> >
> >
> >
> > On Friday, February 28, 2014 3:50 PM, Andrew Grieve <
> agrieve@chromium.org>
> > wrote:
> >
> > On Fri, Feb 28, 2014 at 3:37 PM, Andrew Grieve <ag...@chromium.org>
> > wrote:
> > >
> > >> Note that since we can't re-upload to NPM with the same versions, I've
> > >> bumped the version since my first attempt.
> > >>
> > >> If you'd like to verify the files on dist/, you can now clone the repo
> > via:
> > >> ./cordova-coho/coho repo-clone -r dist/dev
> > >>
> > >> And check the hashes & signature with:
> > >> ./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
> > >>
> > >> There's no logic there to check the actual contents of the zip yet
> > though
> > >> (if someone feels like adding this, please do!)
> > >>
> > >Actually, you could just build the archive and use diff to verify the
> > >contents:
> > >./cordova-coho/coho create-archive -r plugman -r cli --no-sign --dest .
> > >diff plugman*.zip cordova-dist-dev/CB-6115/plugman*.zip
> > >diff cordova*.zip cordova-dist-dev/CB-6115/cordova*.zip
> > >
> > >
> > >
> > >>
> > >>
> > >>
> > >> Please review and vote on the release of cordova@3.4.0-0.1.2
> > >> plugman@0.20.1.
> > >>
> > >> Release issue: https://issues.apache.org/jira/browse/CB-6115
> > >>
> > >> Both cordova and plugman have been uploaded to npm with the "rc" tag:
> > >> npm install -g cordova@rc
> > >> npm install -g plugman@rc
> > >>
> > >> They have also been published to dist:
> > >> https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
> > >>
> > >> The packages were published from their corresponding git tags:
> > >> plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
> > >> cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
> > >>
> > >> Upon a successful vote, I will tag the releases as "latest" on NPM and
> > >> post the corresponding blog post.
> > >>
> > >> Voting will go on for 48 hours.
> > >>
> > >
> > >
> > >
> >
>
Re: [Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Posted by Ian Clelland <ic...@chromium.org>.
+1
Checked signatures and hashes. Checked diffs (not too crude a tool) against
the corresponding tags in the repos.
Installed both plugman and CLI; both appear to be working correctly,
building projects, adding and removing plugins, building and deploying to
Android devices.
On Fri, Feb 28, 2014 at 4:00 PM, Joe Schaefer <jo...@yahoo.com>wrote:
> If diff is a little too crude for this purpose I encourage you to
> take a look at
>
>
> https://svn.apache.org/repos/private/committers/tools/releases/compare_dirs.pl
>
> The way you'd use it is to unzip the two archive files into separate paths
> and invoke this script on those paths. It takes a list of filenames to
> skip as arguments, but those could probably be scripted away into a wrapper
> call around it.
>
>
>
>
> On Friday, February 28, 2014 3:50 PM, Andrew Grieve <ag...@chromium.org>
> wrote:
>
> On Fri, Feb 28, 2014 at 3:37 PM, Andrew Grieve <ag...@chromium.org>
> wrote:
> >
> >> Note that since we can't re-upload to NPM with the same versions, I've
> >> bumped the version since my first attempt.
> >>
> >> If you'd like to verify the files on dist/, you can now clone the repo
> via:
> >> ./cordova-coho/coho repo-clone -r dist/dev
> >>
> >> And check the hashes & signature with:
> >> ./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
> >>
> >> There's no logic there to check the actual contents of the zip yet
> though
> >> (if someone feels like adding this, please do!)
> >>
> >Actually, you could just build the archive and use diff to verify the
> >contents:
> >./cordova-coho/coho create-archive -r plugman -r cli --no-sign --dest .
> >diff plugman*.zip cordova-dist-dev/CB-6115/plugman*.zip
> >diff cordova*.zip cordova-dist-dev/CB-6115/cordova*.zip
> >
> >
> >
> >>
> >>
> >>
> >> Please review and vote on the release of cordova@3.4.0-0.1.2
> >> plugman@0.20.1.
> >>
> >> Release issue: https://issues.apache.org/jira/browse/CB-6115
> >>
> >> Both cordova and plugman have been uploaded to npm with the "rc" tag:
> >> npm install -g cordova@rc
> >> npm install -g plugman@rc
> >>
> >> They have also been published to dist:
> >> https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
> >>
> >> The packages were published from their corresponding git tags:
> >> plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
> >> cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
> >>
> >> Upon a successful vote, I will tag the releases as "latest" on NPM and
> >> post the corresponding blog post.
> >>
> >> Voting will go on for 48 hours.
> >>
> >
> >
> >
>
Re: [Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Posted by Joe Schaefer <jo...@yahoo.com>.
If diff is a little too crude for this purpose I encourage you to
take a look at
https://svn.apache.org/repos/private/committers/tools/releases/compare_dirs.pl
The way you'd use it is to unzip the two archive files into separate paths
and invoke this script on those paths. It takes a list of filenames to skip as arguments, but those could probably be scripted away into a wrapper call around it.
On Friday, February 28, 2014 3:50 PM, Andrew Grieve <ag...@chromium.org> wrote:
On Fri, Feb 28, 2014 at 3:37 PM, Andrew Grieve <ag...@chromium.org> wrote:
>
>> Note that since we can't re-upload to NPM with the same versions, I've
>> bumped the version since my first attempt.
>>
>> If you'd like to verify the files on dist/, you can now clone the repo via:
>> ./cordova-coho/coho repo-clone -r dist/dev
>>
>> And check the hashes & signature with:
>> ./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
>>
>> There's no logic there to check the actual contents of the zip yet though
>> (if someone feels like adding this, please do!)
>>
>Actually, you could just build the archive and use diff to verify the
>contents:
>./cordova-coho/coho create-archive -r plugman -r cli --no-sign --dest .
>diff plugman*.zip cordova-dist-dev/CB-6115/plugman*.zip
>diff cordova*.zip cordova-dist-dev/CB-6115/cordova*.zip
>
>
>
>>
>>
>>
>> Please review and vote on the release of cordova@3.4.0-0.1.2
>> plugman@0.20.1.
>>
>> Release issue: https://issues.apache.org/jira/browse/CB-6115
>>
>> Both cordova and plugman have been uploaded to npm with the "rc" tag:
>> npm install -g cordova@rc
>> npm install -g plugman@rc
>>
>> They have also been published to dist:
>> https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
>>
>> The packages were published from their corresponding git tags:
>> plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
>> cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
>>
>> Upon a successful vote, I will tag the releases as "latest" on NPM and
>> post the corresponding blog post.
>>
>> Voting will go on for 48 hours.
>>
>
>
>
Re: [Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Posted by Andrew Grieve <ag...@chromium.org>.
On Fri, Feb 28, 2014 at 3:37 PM, Andrew Grieve <ag...@chromium.org> wrote:
> Note that since we can't re-upload to NPM with the same versions, I've
> bumped the version since my first attempt.
>
> If you'd like to verify the files on dist/, you can now clone the repo via:
> ./cordova-coho/coho repo-clone -r dist/dev
>
> And check the hashes & signature with:
> ./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
>
> There's no logic there to check the actual contents of the zip yet though
> (if someone feels like adding this, please do!)
>
Actually, you could just build the archive and use diff to verify the
contents:
./cordova-coho/coho create-archive -r plugman -r cli --no-sign --dest .
diff plugman*.zip cordova-dist-dev/CB-6115/plugman*.zip
diff cordova*.zip cordova-dist-dev/CB-6115/cordova*.zip
>
>
>
> Please review and vote on the release of cordova@3.4.0-0.1.2
> plugman@0.20.1.
>
> Release issue: https://issues.apache.org/jira/browse/CB-6115
>
> Both cordova and plugman have been uploaded to npm with the "rc" tag:
> npm install -g cordova@rc
> npm install -g plugman@rc
>
> They have also been published to dist:
> https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
>
> The packages were published from their corresponding git tags:
> plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
> cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
>
> Upon a successful vote, I will tag the releases as "latest" on NPM and
> post the corresponding blog post.
>
> Voting will go on for 48 hours.
>
Re: [Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Posted by Andrew Grieve <ag...@chromium.org>.
Thanks for pointing that out. Lots of places to put your key! I've added my
key to dist/release/cordova/KEYS.
FYI - All of my gpg learning has been documented here:
https://wiki.apache.org/cordova/SetUpGpg
On Fri, Feb 28, 2014 at 4:02 PM, sebb <se...@gmail.com> wrote:
> On 28 February 2014 20:37, Andrew Grieve <ag...@chromium.org> wrote:
> > Note that since we can't re-upload to NPM with the same versions, I've
> > bumped the version since my first attempt.
> >
> > If you'd like to verify the files on dist/, you can now clone the repo
> via:
> > ./cordova-coho/coho repo-clone -r dist/dev
> >
> > And check the hashes & signature with:
> > ./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
> >
> > There's no logic there to check the actual contents of the zip yet though
> > (if someone feels like adding this, please do!)
> >
> >
> >
> > Please review and vote on the release of cordova@3.4.0-0.1.2
> plugman@0.20.1.
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-6115
> >
> > Both cordova and plugman have been uploaded to npm with the "rc" tag:
> > npm install -g cordova@rc
> > npm install -g plugman@rc
> >
> > They have also been published to dist:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
>
> It would be helpful to include the signing key (8A496450) in the KEYS file
> at
>
> https://dist.apache.org/repos/dist/release/cordova/KEYS
>
> At present that only contains the key for Steven Gill.
>
> > The packages were published from their corresponding git tags:
> > plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
> > cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
> >
> > Upon a successful vote, I will tag the releases as "latest" on NPM and
> post
> > the corresponding blog post.
> >
> > Voting will go on for 48 hours.
>
Re: [Vote] cordova@3.4.0-0.1.2 plugman@0.20.1
Posted by sebb <se...@gmail.com>.
On 28 February 2014 20:37, Andrew Grieve <ag...@chromium.org> wrote:
> Note that since we can't re-upload to NPM with the same versions, I've
> bumped the version since my first attempt.
>
> If you'd like to verify the files on dist/, you can now clone the repo via:
> ./cordova-coho/coho repo-clone -r dist/dev
>
> And check the hashes & signature with:
> ./cordova-coho/coho verify-archive cordova-dist-dev/$JIRA/*.zip
>
> There's no logic there to check the actual contents of the zip yet though
> (if someone feels like adding this, please do!)
>
>
>
> Please review and vote on the release of cordova@3.4.0-0.1.2 plugman@0.20.1.
>
> Release issue: https://issues.apache.org/jira/browse/CB-6115
>
> Both cordova and plugman have been uploaded to npm with the "rc" tag:
> npm install -g cordova@rc
> npm install -g plugman@rc
>
> They have also been published to dist:
> https://dist.apache.org/repos/dist/dev/cordova/CB-6115/
It would be helpful to include the signing key (8A496450) in the KEYS file at
https://dist.apache.org/repos/dist/release/cordova/KEYS
At present that only contains the key for Steven Gill.
> The packages were published from their corresponding git tags:
> plugman: 0.20.1 (6a827cc28167a31f9d3c1196303b0910ad87ec5a)
> cli: 3.4.0-0.1.2 (d9097de6b00a4ff39e3250bac36d343ff23294ad)
>
> Upon a successful vote, I will tag the releases as "latest" on NPM and post
> the corresponding blog post.
>
> Voting will go on for 48 hours.