[jira] [Updated] (SOLR-6616) Make shards.tolerant and timeAllowed work together

["Steve Molloy (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Molloy updated SOLR-6616:
-------------------------------
    Attachment: SOLR-6616.patch

This patch only returns partialResults if shards.tolerant was true. It also adds some timeout checks during distributed processing to cancel pending tasks when timing out. This avoid components to keep sending shard requests (for facet pivot refinement for instance) even after timing out.

We may want to rename "shards.tolerant" to reflect the fact that it now also affects non-distributed requests. It should be specific to accepting partial results, no matter if it is distributed or not.

> Make shards.tolerant and timeAllowed work together
> --------------------------------------------------
>
>                 Key: SOLR-6616
>                 URL: https://issues.apache.org/jira/browse/SOLR-6616
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>         Attachments: SOLR-6616.patch
>
>
> From SOLR-5986:
> {quote}
> As of now, when timeAllowed is set, we never get back an exception but just partialResults in the response header is set to true in case of a shard failure. This translates to shards.tolerant being ignored in that case.
> On the code level, the TimeExceededException never reaches ShardHandler and so the Exception is never set (similarly for ExitingReaderException) and/or returned to the client.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org