[jira] [Comment Edited] (WICKET-5265) FencedFeedbackPanel is broken with RefreshingView(and it's implementations)

["Carl-Eric Menzel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098828#comment-14098828 ] 

Carl-Eric Menzel edited comment on WICKET-5265 at 8/15/14 8:14 PM:
-------------------------------------------------------------------

Not really. onInitialize is a very different thing. It's only called exactly once and is basically a delayed constructor. I need something that will be called whenever a component is added *or re-added* to the page component tree. onRemove is called on the entire tree that is removed, we have no complement for that when something is added back.

I've tried it, and it fixed the problem in this ticket. I'll clean it up a little and push it in a branch so you can have a look at it.


was (Author: cmenzel):
No. onInitialize is a very different thing. It's only called exactly once and is basically a delayed constructor. I need something that will be called whenever a component is added *or re-added* to the page component tree. onRemove is called on the entire tree that is removed, we have no complement for that when something is added back.

I've tried it, and it fixed the problem in this ticket. I'll clean it up a little and push it in a branch so you can have a look at it.

> FencedFeedbackPanel is broken with RefreshingView(and it's implementations)
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-5265
>                 URL: https://issues.apache.org/jira/browse/WICKET-5265
>             Project: Wicket
>          Issue Type: Bug
>            Reporter: vineet semwal
>            Assignee: Carl-Eric Menzel
>              Labels: DataView, FencedFeedbackPanel, RefreshingView
>         Attachments: 0001-WICKET-5265-recreate-fence-mark-when-needed.patch, WICKET-5265.patch, second.patch
>
>
> FencedFeedbackPanel doesn't work correctly if inner form(s) are in RefreshingView(or it's implementations)..
> in this case outerform feedbackpanel just starts including messages meant for inner feedbackpanel.
> with ListView FencedFeedbackPanel works correctly..
> actually one user(Mike Dundee) created this issue in quickview https://github.com/vineetsemwal/quickview/issues/19
>  so in that link he has described his problem and pasted the code you can use to reproduce ...
> there i have also explained why it's broken with RefreshingView and it's implementations currently(it's a little complex so i am trying to avoid explaining all again ,also english is not my first language :-) ) 
> thank you !



--
This message was sent by Atlassian JIRA
(v6.2#6252)