[jira] [Comment Edited] (FLINK-16998) Add a changeflag to Row type

["Timo Walther (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099696#comment-17099696 ] 

Timo Walther edited comment on FLINK-16998 at 5/5/20, 9:15 AM:
---------------------------------------------------------------

[~jark] [~dwysakowicz] before I do the big refactoring of tests. I just would like to double check if we are fine with the following string format:
{code}
System.out.println(Row.ofKind(RowKind.DELETE, 12, 12, Row.of("Hello", "World")));
{code}
results in
{code}
-D(12, 12, +I(Hello, World))
{code}


was (Author: twalthr):
[~jark] [~dwysakowicz] before I do the big refactoring of tests. I just would like to double check if we are fine with the following string format:
{code}
System.out.println(Row.ofKind(RowKind.DELETE, 12, 12, Row.of("Hello", "World")));
{code}
results in
{code}
-D(12,12,+I(Hello,World))
{code}

> Add a changeflag to Row type
> ----------------------------
>
>                 Key: FLINK-16998
>                 URL: https://issues.apache.org/jira/browse/FLINK-16998
>             Project: Flink
>          Issue Type: Sub-task
>          Components: API / Core
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>
> In Blink planner, the change flag of records travelling through the pipeline are part of the record itself but not part of the logical schema. This simplifies the architecture and API in many cases.
> Which is why we aim adopt the same mechanism for {{org.apache.flink.types.Row}}.
> Take {{tableEnv.toRetractStream()}} as an example that returns either Scala or Java {{Tuple2<Boolean, Row>}}. For FLIP-95 we need to support more update kinds than just a binary boolean.
> This means:
> - Add a changeflag {{RowKind}} to to {{Row}}
> - Update the {{Row.toString()}} method
> - Update serializers in backwards compatible way



--
This message was sent by Atlassian Jira
(v8.3.4#803005)