You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/09 17:42:03 UTC
[GitHub] [yunikorn-core] bgrams opened a new pull request, #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup
bgrams opened a new pull request, #471:
URL: https://github.com/apache/yunikorn-core/pull/471
### What is this PR for?
Completed applications are stored permanently in 2 places - the PartitionContext and the application Queue. #463 ensured that these are permanently removed from the PC. This PR ensures that the Queue is considered in the cleanup loop as well.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1440
### How should this be tested?
Tests added
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #471:
URL: https://github.com/apache/yunikorn-core/pull/471#issuecomment-1344587932
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#471](https://codecov.io/gh/apache/yunikorn-core/pull/471?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33cf961) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/020bbd8544fd29743b2284e473695221de552826?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (020bbd8) will **increase** coverage by `0.00%`.
> The diff coverage is `78.94%`.
```diff
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 72.88% 72.89%
=======================================
Files 67 67
Lines 10057 10074 +17
=======================================
+ Hits 7330 7343 +13
- Misses 2482 2486 +4
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/471/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.01% <0.00%> (-0.32%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/yunikorn-core/pull/471/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `78.02% <100.00%> (+0.28%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #471:
URL: https://github.com/apache/yunikorn-core/pull/471#issuecomment-1345769875
As I discussed with Brandon off-line: YUNIKORN-800 introduced this leak and did not take into account dynamic queues and application ID reuse (i.e. K8s CronJob).
Completed applications should not be linked to the queue anymore. If we want them accessible based on the queue(path) we should allow a filter on the partition applications call.
In the case that we have a dynamic queue: the queue will be removed long before the the completed application expires. Our main use cases have always used dynamic queues and that is one of the reasons why we did not see this issue. This is a workaround. It fixes the leak but nothing else. We should properly fix this the issues introduced in YUNIKORN-800 and the leak in one go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] bgrams commented on pull request #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup
Posted by GitBox <gi...@apache.org>.
bgrams commented on PR #471:
URL: https://github.com/apache/yunikorn-core/pull/471#issuecomment-1345777019
Yep, thanks Wilfred. We're fine running this patch as a temp fix until 1.2.
I'll close the PR. Happy to pitch in on the broader fix as-needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] bgrams closed pull request #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup
Posted by GitBox <gi...@apache.org>.
bgrams closed pull request #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup
URL: https://github.com/apache/yunikorn-core/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org