[jira] [Comment Edited] (KAFKA-566) Add last modified time to the TopicMetadataRequest

["Madhusudan C.S. (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478330#comment-13478330 ] 

Madhusudan C.S. edited comment on KAFKA-566 at 10/17/12 11:54 PM:
------------------------------------------------------------------

Makes sense, I will see if I can implement them. Btw, do we already have getMetadataRequest call implemented? I looked it up and I could not find it. Or does TopicMetadataRequest translate to getMetadataRequest for clients?
                
      was (Author: madhusudancs):
    Makes sense, I will see if I can implement them. Btw, do we already have getMetadataRequest call implemented? I looked it up and I could not find it. Or does TopicMetadataRequest translates to getMetadataRequest for clients?
                  
> Add last modified time to the TopicMetadataRequest
> --------------------------------------------------
>
>                 Key: KAFKA-566
>                 URL: https://issues.apache.org/jira/browse/KAFKA-566
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Priority: Blocker
>             Fix For: 0.8
>
>
> To support KAFKA-560 it would be nice to have a last modified time in the TopicMetadataRequest. This would be the timestamp of the last append to the log as taken from stat on the final log segment.
> Implementation would involve
> 1. Adding a new field to TopicMetadataRequest
> 2. Adding a method Log.lastModified: Long to get the last modified time from a log
> This timestamp would, of course, be subject to error in the event that the file was touched without modification, but I think that is actually okay since it provides a manual way to avoid gc'ing a topic that you  know you will want.
> It is debatable whether this should go in 0.8. It would be nice to add the field to the metadata request, at least, as that change should be easy and would avoid needing to bump the version in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira