You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/02 21:30:41 UTC

[kudu-CR] util: deadline for BlockingQueue::Blocking{Put,Get}

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15324

to look at the new patch set (#2).

Change subject: util: deadline for BlockingQueue::Blocking{Put,Get}
......................................................................

util: deadline for BlockingQueue::Blocking{Put,Get}

Drawing inspiration from BlockingDrainTo(), this adds a deadline to
BlockingPut() and BlockingGet(), with the same error semantics.

This also updates SubprocessServer to use of BlockingPut(), instead of
manual deadline-checking.

Change-Id: If32bad5667195d72eeb03e4942751824d4dadb7a
---
M src/kudu/consensus/log.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/subprocess_server-test.cc
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/blocking_queue.h
6 files changed, 138 insertions(+), 68 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15324/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If32bad5667195d72eeb03e4942751824d4dadb7a
Gerrit-Change-Number: 15324
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)