You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/18 08:56:41 UTC
[GitHub] [kafka] Sasilekha opened a new pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer
Sasilekha opened a new pull request #9195:
URL: https://github.com/apache/kafka/pull/9195
In NioEchoServer the enum has its constructor declared as private, which is redundant. We can remove this.
public class NioEchoServer extends Thread {
public enum MetricType {
TOTAL, RATE, AVG, MAX;
private final String metricNameSuffix;
private MetricType() {
metricNameSuffix = "-" + name().toLowerCase(Locale.ROOT);
}}}
Removed the MetricType constructor for the MetricType Enum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9195:
URL: https://github.com/apache/kafka/pull/9195#issuecomment-716305990
@Sasilekha Sorry that I'm going to close this PR as https://github.com/apache/kafka/pull/8794 is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9195:
URL: https://github.com/apache/kafka/pull/9195#issuecomment-714341174
@Sasilekha This PR is duplicate to https://github.com/apache/kafka/pull/8794 which was created before your PR (Also, https://issues.apache.org/jira/browse/KAFKA-10092 is assigned to author of #8794). In oder to keep community clean, #8794 get higher priority of reviews.
There are a lot of tickets in jira so you can take over the unassigned one if you have free time. Also, please feel free to ping me if you have other pending PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 closed pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer
Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #9195:
URL: https://github.com/apache/kafka/pull/9195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Sasilekha commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer
Posted by GitBox <gi...@apache.org>.
Sasilekha commented on pull request #9195:
URL: https://github.com/apache/kafka/pull/9195#issuecomment-675358144
Hi @ notifygd
Can you please review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org