You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by pt...@apache.org on 2014/08/08 21:48:23 UTC
[12/50] [abbrv] git commit: mark prepare() method as final
mark prepare() method as final
Project: http://git-wip-us.apache.org/repos/asf/incubator-storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-storm/commit/20be88f5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-storm/tree/20be88f5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-storm/diff/20be88f5
Branch: refs/heads/master
Commit: 20be88f5dae7af8bd4a749731ee8a6890c249942
Parents: 23a6375
Author: P. Taylor Goetz <pt...@gmail.com>
Authored: Fri May 30 11:26:40 2014 -0400
Committer: P. Taylor Goetz <pt...@gmail.com>
Committed: Fri May 30 11:26:40 2014 -0400
----------------------------------------------------------------------
.../java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-storm/blob/20be88f5/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java b/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
index 3d3a3c1..dfe550d 100644
--- a/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
+++ b/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
@@ -49,7 +49,6 @@ public abstract class AbstractHdfsBolt extends BaseRichBolt {
protected int rotation = 0;
protected String fsUrl;
protected String configKey;
-// protected String path;
protected Configuration hdfsConfig;
@@ -69,7 +68,13 @@ public abstract class AbstractHdfsBolt extends BaseRichBolt {
LOG.info("File rotation took {} ms.", time);
}
- public void prepare(Map conf, TopologyContext topologyContext, OutputCollector collector){
+ /**
+ * Marked as final to prevent override. Subclasses should implement the doPrepare() method.
+ * @param conf
+ * @param topologyContext
+ * @param collector
+ */
+ public final void prepare(Map conf, TopologyContext topologyContext, OutputCollector collector){
if (this.syncPolicy == null) throw new IllegalStateException("SyncPolicy must be specified.");
if (this.rotationPolicy == null) throw new IllegalStateException("RotationPolicy must be specified.");
if (this.fsUrl == null) {