You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/22 06:19:32 UTC

[GitHub] [arrow] zhztheplayer commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

zhztheplayer commented on a change in pull request #10201:
URL: https://github.com/apache/arrow/pull/10201#discussion_r637362031



##########
File path: java/dataset/src/main/java/org/apache/arrow/dataset/jni/JniWrapper.java
##########
@@ -52,7 +52,7 @@ private JniWrapper() {
    * Create Dataset from a DatasetFactory and get the native pointer of the Dataset.
    *
    * @param datasetFactoryId the native pointer of the arrow::dataset::DatasetFactory instance.
-   * @param schema the predefined schema of the resulting Dataset.
+   * @param schema           the predefined schema of the resulting Dataset.

Review comment:
       Thanks! But I don't see we always make consistent practices of Javadoc alignment in Arrow Java code. E.g.
   
   https://github.com/apache/arrow/blob/78c88a9f517b540ea010a6bd6a8c8f6d91769559/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/JniWrapper.java#L34-L40
   
   Maybe what we need here is to add a relevant rule to checkstyle config and do a complete clean up?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org