You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/02/23 08:12:28 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1267: [CELEBORN-332] Unify the log of ShuffleClientImpl
AngersZhuuuu opened a new pull request, #1267:
URL: https://github.com/apache/incubator-celeborn/pull/1267
### What changes were proposed in this pull request?
Current log in `ShuffleClientImpl` have below problem:
1. Use `logger.error` but can't show error stack
2. Different format of log
3. Wrong log level of error type log
In this pr, I prefer to unify the log format
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1267: [CELEBORN-332] Unify the log of ShuffleClientImpl
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1267:
URL: https://github.com/apache/incubator-celeborn/pull/1267#discussion_r1115559432
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -187,11 +187,34 @@ private void submitRetryPushData(
new CelebornIOException("Revive Failed, remain revive times " + remainReviveTimes));
} else if (mapperEnded(shuffleId, mapId, attemptId)) {
logger.debug(
- "Retrying push data, but the mapper(map {} attempt {}) has ended.", mapId, attemptId);
+ "Revive for push data success, but the mapper already ended for shuffle "
Review Comment:
let's use the "{}" style, as we discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1267: [CELEBORN-332] Unify the log of ShuffleClientImpl
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1267:
URL: https://github.com/apache/incubator-celeborn/pull/1267#discussion_r1116471782
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -187,11 +187,34 @@ private void submitRetryPushData(
new CelebornIOException("Revive Failed, remain revive times " + remainReviveTimes));
} else if (mapperEnded(shuffleId, mapId, attemptId)) {
logger.debug(
- "Retrying push data, but the mapper(map {} attempt {}) has ended.", mapId, attemptId);
+ "Revive for push data success, but the mapper already ended for shuffle "
Review Comment:
> let's use the "{}" style, as we discussed.
How about current?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1267: [CELEBORN-332] Unify the log of ShuffleClientImpl
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1267:
URL: https://github.com/apache/incubator-celeborn/pull/1267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1267: [CELEBORN-332] Unify the log of ShuffleClientImpl
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1267:
URL: https://github.com/apache/incubator-celeborn/pull/1267#issuecomment-1441361690
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1267](https://codecov.io/gh/apache/incubator-celeborn/pull/1267?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c1184b) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/3067efcfd31475fc44c38fad0813fd3350a55f57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3067efc) will **increase** coverage by `0.06%`.
> The diff coverage is `2.95%`.
```diff
@@ Coverage Diff @@
## main #1267 +/- ##
============================================
+ Coverage 27.12% 27.18% +0.06%
- Complexity 813 814 +1
============================================
Files 215 215
Lines 18364 18291 -73
Branches 1999 1999
============================================
- Hits 4979 4970 -9
+ Misses 13061 12998 -63
+ Partials 324 323 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/celeborn/client/ShuffleClientImpl.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvU2h1ZmZsZUNsaWVudEltcGwuamF2YQ==) | `18.59% <2.95%> (+0.43%)` | :arrow_up: |
| [...oy/worker/congestcontrol/CongestionController.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvY29uZ2VzdGNvbnRyb2wvQ29uZ2VzdGlvbkNvbnRyb2xsZXIuamF2YQ==) | `77.78% <0.00%> (+0.93%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org