[jira] [Commented] (OOZIE-3031) Coord job with only unresolved dependencies doesn't timeout

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124408#comment-16124408 ] 

Hadoop QA commented on OOZIE-3031:
----------------------------------

Testing JIRA OOZIE-3031

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
.    {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:red}-1{color} There are [1] new bugs found below threshold in [core] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html
. The most important FindBugs errors are:
. At CoordActionInputCheckXCommand.java:[line 174]: Dead store to nonExistListStr in org.apache.oozie.command.coord.CoordActionInputCheckXCommand.execute()
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 2011
.    Tests rerun: 58
.    Tests failed at first run: org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener,
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/4036/

> Coord job with only unresolved dependencies doesn't timeout
> -----------------------------------------------------------
>
>                 Key: OOZIE-3031
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3031
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>            Assignee: Purshotam Shah
>            Priority: Critical
>         Attachments: OOZIE-3031-V1.patch
>
>
> {code:title=CoordActionInputCheckXCommand.java}
> else if (!isTimeout(currentTime)) {
>                 if (!status) {
>                     long addtionalDelay = isChangeInDependency ? 0
>                             : ConfigurationService.getInt(CONF_COORD_INPUT_CHECK_REQUEUE_INTERVAL_ADDITIONAL_DELAY)
>                                     * 1000L;
>                     queue(new CoordActionInputCheckXCommand(coordAction.getId(), coordAction.getJobId()),
>                             addtionalDelay + getCoordInputCheckRequeueInterval());
>                 }
>                 updateCoordAction(coordAction, isChangeInDependency);
>             }
>             else {
>                 if (!nonExistListStr.isEmpty() && isPushDependenciesMet) {
>                     queue(new CoordActionTimeOutXCommand(coordAction, coordJob.getUser(), coordJob.getAppName()));
>                 }
>                 else {
>                     // Let CoordPushDependencyCheckXCommand queue the timeout
>                     queue(new CoordPushDependencyCheckXCommand(coordAction.getId()));
>                 }
>                 updateCoordAction(coordAction, isChangeInDependency);
>             }
>         }
> {code}
> {{!nonExistList Str.isEmpty()}} check is unnecessary, once the action has passed the timeout, it should be marked as timedout.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)