[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6668: SumPrecision: support all data types and star-tree

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6668:
URL: https://github.com/apache/incubator-pinot/pull/6668#discussion_r592617634



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/aggregator/SumPrecisionValueAggregator.java
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.data.aggregator;
+
+import java.math.BigDecimal;
+import org.apache.pinot.common.function.AggregationFunctionType;
+import org.apache.pinot.spi.data.FieldSpec.DataType;
+import org.apache.pinot.spi.utils.BigDecimalUtils;
+
+
+public class SumPrecisionValueAggregator implements ValueAggregator<Object, BigDecimal> {
+  public static final DataType AGGREGATED_VALUE_TYPE = DataType.BYTES;
+
+  private int _maxByteSize;

Review comment:
       It doesn't really matter as we won't generate star-tree if there is no record. Also, without explicitly putting a value, member variable will be initialized to 0




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org