You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by mino922 <gi...@git.apache.org> on 2017/10/06 04:29:14 UTC
[GitHub] cordova-plugin-camera pull request #289: CB-133332: (iOS) Error When Taking ...
GitHub user mino922 opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/289
CB-133332: (iOS) Error When Taking Picture Missing NSPhotoLibraryAddU…
…sageDescription
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fixes issues in iOS when taking a photo where app would crash because of missing NSPhotoLibraryUsageDescription
### What testing has been done on this change?
Change was tested on an ionic app on iPhone 6s running iOS 11.
### Checklist
- [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mino922/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #289
----
commit a951cade16fc9206ada28ceff3980bc921b494ca
Author: mino922 <sa...@gmail.com>
Date: 2017-10-06T04:24:21Z
CB-133332 iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #289: CB-13332: (iOS) Error When Taking Picture ...
Posted by mino922 <gi...@git.apache.org>.
Github user mino922 commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/289
To use this, you must add to your config.xml
`<variable name="PHOTOLIBRARY_ADD_USAGE_DESCRIPTION" value="Access Photo Library for Profile Picture" />`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #289: CB-13332: (iOS) Error When Taking P...
Posted by mino922 <gi...@git.apache.org>.
Github user mino922 closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/289
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #289: CB-13332: (iOS) Error When Taking Picture ...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/289
Thanks for you PR, but you are just duplicating NSPhotoLibraryUsageDescription, the one needed for iOS 11 is NSPhotoLibraryAddUsageDescription.
Anyway, we are removing the preferences like this from the plugin.xml as it causes conflicts with other plugins requiring the same permissions.
The correct way of adding the permissions is using `edit-config` tag in the config.xml like this
```
<edit-config target="NSPhotoLibraryAddUsageDescription" file="*-Info.plist" mode="merge">
<string>need to save on the photo library for some reason</string>
</edit-config>
```
Can you close the PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org