[GitHub] [incubator-superset] rusackas commented on issue #9338: [SQLLAB] add feature flag to disable auto-complete

[GitBox <gi...@apache.org>]

rusackas commented on issue #9338: [SQLLAB] add feature flag to disable auto-complete
URL: https://github.com/apache/incubator-superset/pull/9338#issuecomment-602272074
 
 
   > I think a toggle within the sql lab UI might be a preferred option here. Thoughts?
   
   I suspect there will be a proliferation of these little preference switches as we go through and implement the SIP-34 redesign. I think rather than having them scattered all over, it might make sense to have a "preferences" pane, either on the Profile view, or on a new view alongside it. There, preferences could be organized by section or theme, and organized hierarchically if needed. I'm happy to take a stab at a design pattern for that.
   
   All that said, a new view seems outside the scope of this ticket. If there's a way to make this a user preference rather than an env setting in the shorter term without adding too much complexity here, that seems like a reasonable compromise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org