[jira] [Commented] (YARN-6055) ContainersMonitorImpl need be adjusted when NM resource changed.

["Íñigo Goiri (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637712#comment-16637712 ] 

Íñigo Goiri commented on YARN-6055:
-----------------------------------

The comment from [~raviprak] was:
{quote}
Should we also modify the limits set in [ContainersMonitorImpl.maxPmemAllottedForContainers|https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java#L76] etc. also?
{quote}

I agree on this, {{NodeStatusUpdaterImpl#updateNMResource}} should modify the {{ContainersMonitorImpl}} values.
It should be fairly easy to check it from TestRMAdminService.

I could give it a try.

> ContainersMonitorImpl need be adjusted when NM resource changed.
> ----------------------------------------------------------------
>
>                 Key: YARN-6055
>                 URL: https://issues.apache.org/jira/browse/YARN-6055
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: graceful, nodemanager, scheduler
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Major
>
> Per Ravi's comments in YARN-4832, we need to check some limits in containerMonitorImpl to make sure it get updated also when Resource updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org