[GitHub] [flink] dannycranmer commented on pull request #12944: [FLINK-18513][Kinesis] Add AWS SDK v2.x dependency and KinesisProxyV2

[GitBox <gi...@apache.org>]

dannycranmer commented on pull request #12944:
URL: https://github.com/apache/flink/pull/12944#issuecomment-686388071


   @tzulitai the build issue was caused by running multiple builds without `clean`. For example:
   ```
   mvn package
   mvn package
   ```
   
   The files left hanging around were not being overridden by the shade plugin. The `org.apache.maven.plugins.shade.resource.ServicesResourceTransformer` configuration is inherited by an ancestor pom. I have verified that these service manifest files are not required by the connector and removed them from the shaded jar (if you know a different/better way to configure this plugin, happy to swap it out):
   
   ```
     META-INF/services/reactor.blockhound.integration.BlockHoundIntegration
   - META-INF/services/org.apache.flink.kinesis.shaded.software.amazon.awssdk.http.async.SdkAsyncHttpService
   - META-INF/services/org.apache.flink.kinesis.shaded.software.amazon.awssdk.http.SdkHttpService
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org