You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2010/10/22 18:16:17 UTC
[jira] Created: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Provide more DirectoryFactory implementations for the various different Directories
-----------------------------------------------------------------------------------
Key: SOLR-2187
URL: https://issues.apache.org/jira/browse/SOLR-2187
Project: Solr
Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Minor
Fix For: 3.1, 4.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll updated SOLR-2187:
----------------------------------
Attachment: SOLR-2187.patch
Provide MMap and SimpleFS DirectoryFactory impls. Didn't include the DirectIOLinuxDirectory yet, since that still seems highly experimental.
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923914#action_12923914 ]
Robert Muir commented on SOLR-2187:
-----------------------------------
For the MMap one, I think it would be good to at least provide options to:
# enable the unmapHack if its supported (MMapDirectory.UNMAP_SUPPORTED). This is the default in 4.x, but not in 3.x. Might want to do this one by default, if its supported.
# set the maximum chunk size (setMaxChunkSize). If you try to use this on a 32-bit jvm, then you might need this so mmap won't fail.
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923954#action_12923954 ]
Grant Ingersoll commented on SOLR-2187:
---------------------------------------
bq. enable the unmapHack if its supported (MMapDirectory.UNMAP_SUPPORTED). This is the default in 4.x, but not in 3.x. Might want to do this one by default, if its supported.
What do you think should be the behavior if setting it fails? Should we fail completely (i.e. let the exception percolate up) or should we catch it, log it and still provide the MMapDirectory, just w/o the unmap. Seems like, in this case, we should just log it, but others are often of the opinion that we should fail for these kinds of things.
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923967#action_12923967 ]
Grant Ingersoll commented on SOLR-2187:
---------------------------------------
OK, I will commit and, gasp, merge to 3.x!
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch, SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll updated SOLR-2187:
----------------------------------
Attachment: SOLR-2187.patch
Incorporates Muir's feedback.
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch, SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923965#action_12923965 ]
Robert Muir commented on SOLR-2187:
-----------------------------------
+1, looks like a good idea for 64-bit windows users of 3.x, for example (since FSDirectory.open still defaults to SimpleFSDirectory for them)
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch, SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2187) Provide more DirectoryFactory
implementations for the various different Directories
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923956#action_12923956 ]
Robert Muir commented on SOLR-2187:
-----------------------------------
{quote}
What do you think should be the behavior if setting it fails? Should we fail completely (i.e. let the exception percolate up) or should we catch it, log it and still provide the MMapDirectory, just w/o the unmap. Seems like, in this case, we should just log it, but others are often of the opinion that we should fail for these kinds of things.
{quote}
well you can check the static boolean (MMapDirectory.UNMAP_SUPPORTED) yourself, when initializing the factory.
then you could throw an exception if someone tries to enable the option, but the underlying jvm doesnt support it.
in practice i think you could enable the option in the config xml by example/default... because this works on all major jvms: Sun, IBM, Oracle JRockit, etc.
It won't work on apache harmony for example, and probably other jvms, but does Solr even work at all on those anyway?
> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
> Key: SOLR-2187
> URL: https://issues.apache.org/jira/browse/SOLR-2187
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2187.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org