You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/06 18:42:50 UTC
[GitHub] [kafka] gharris1727 opened a new pull request, #13086: KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering
gharris1727 opened a new pull request, #13086:
URL: https://github.com/apache/kafka/pull/13086
The ACL change methods (create, delete) are eventually consistent across a Kafka cluster. As part of that, changes to the same resource made to different brokers may be reordered. In this test, a delete operation initiated in noConsumeWithoutDescribeAclSetup was being reordered to an unexpected time later in the test, causing an expected ACL to be missing.
To fix this, add a wait condition that asserts that the delete operations initiated in noConsumeWithoutDescribeAclSetup are completely applied before returning from the method.
Note: test failures were present for both the ZK and KRAFT iterations of the test, but the ZK iteration encountered it much more often, and was used to diagnose the reordering.
Signed-off-by: Greg Harris <gr...@aiven.io>
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gharris1727 commented on pull request #13086: KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering
Posted by GitBox <gi...@apache.org>.
gharris1727 commented on PR #13086:
URL: https://github.com/apache/kafka/pull/13086#issuecomment-1374008851
The last people working in this area were @pprovenzano @omkreddy and @soarez, if any of you have some time i'd appreciate a review on this test which flakes ~10-20% of the time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy merged pull request #13086: KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering
Posted by GitBox <gi...@apache.org>.
omkreddy merged PR #13086:
URL: https://github.com/apache/kafka/pull/13086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy commented on pull request #13086: KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering
Posted by GitBox <gi...@apache.org>.
omkreddy commented on PR #13086:
URL: https://github.com/apache/kafka/pull/13086#issuecomment-1374517980
Test failures are unrelated, merging the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org