You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 19:56:27 UTC

[GitHub] [airflow] jaketf opened a new issue #11093: Add helm chart linting to precommit

jaketf opened a new issue #11093:
URL: https://github.com/apache/airflow/issues/11093


   **Description**
   
   I'd like to add `helm lint` to the pre-commit for apache airflow
   This could run basic linting with some linter values using this existing pre-commit 
   https://github.com/gruntwork-io/pre-commit#helm-lint-caveats
   
   **Use case / motivation**
   This can help developers catch errors sooner if they accidentally modify the helm chart that causes linter to fail.
   
   cc: @potiuk 
   
   **Related Issues**
   
   <!-- Is there currently another issue associated with this? -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #11093: Add helm chart linting to precommit

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11093:
URL: https://github.com/apache/airflow/issues/11093#issuecomment-705093027


   Ahh. It's already added in #11108 . I missed that one in Airflow to close :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dimberman commented on issue #11093: Add helm chart linting to precommit

Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #11093:
URL: https://github.com/apache/airflow/issues/11093#issuecomment-705080618


   @jaketf That's great idea! Feel free to ping me when you have a PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #11093: Add helm chart linting to precommit

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #11093:
URL: https://github.com/apache/airflow/issues/11093


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org