[PR] [FLINK-34715][cdc-connector][mysql] Fix mysql ut about closing BinlogSplitReader [flink-cdc]

["gong (via GitHub)" <gi...@apache.org>]

gong opened a new pull request, #3161:
URL: https://github.com/apache/flink-cdc/pull/3161

   BinlogSplitReaderTest#readBinlogSplitsFromSnapshotSplits should test binlog reader is closed after binlog reader close. But code always test snapshot split reader is closed.
   ```java
   binlogReader.close();
   assertNotNull(snapshotSplitReader.getExecutorService());
   assertTrue(snapshotSplitReader.getExecutorService().isTerminated());
   ```
   
   We shoud change code to 
   ```java
   binlogReader.close();
   assertNotNull(binlogReader.getExecutorService());
   assertTrue(binlogReader.getExecutorService().isTerminated());  
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34715][cdc-connector][mysql] Fix mysql ut about closing BinlogSplitReader [flink-cdc]

["leonardBang (via GitHub)" <gi...@apache.org>]

leonardBang merged PR #3161:
URL: https://github.com/apache/flink-cdc/pull/3161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org