[GitHub] [spark] HeartSaVioR commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter

[GitBox <gi...@apache.org>]

HeartSaVioR commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913393690


   I'm not sure these special notions are interpreted into "timestamp" in consistent way. No doubt they have clear semantics when they are used as "date", but I'm not very clear whether the "yesterday" should be interpreted to the yesterday  "00:00:00".
   
   Suppose two sentences:
   
   * "Spark will read the files which are modified before yesterday."
   * "Spark will read the files which are modified after yesterday."
   
   How we interpret these sentences? Is the time point (in timestamp) of "yesterday" same for both sentences?
   
   For me, all files modified in yesterday should be excluded in both sentences, but it won't be interpreted like that if we consider the semantic of "yesterday" as yesterday "00:00:00".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org