You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/11 12:02:12 UTC
[GitHub] [flink] libenchao commented on a change in pull request #11058:
[FLINK-15995][Table-planner-blink] Change TO_BASE64 sql operator defination
libenchao commented on a change in pull request #11058: [FLINK-15995][Table-planner-blink] Change TO_BASE64 sql operator defination
URL: https://github.com/apache/flink/pull/11058#discussion_r377592907
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -574,9 +574,9 @@ public SqlMonotonicity getMonotonicity(SqlOperatorBinding call) {
public static final SqlFunction TO_BASE64 = new SqlFunction(
"TO_BASE64",
SqlKind.OTHER_FUNCTION,
- VARCHAR_2000_NULLABLE,
+ ReturnTypes.cascade(ReturnTypes.explicit(SqlTypeName.VARCHAR), SqlTypeTransforms.TO_NULLABLE),
null,
- OperandTypes.ANY,
+ OperandTypes.family(SqlTypeFamily.STRING),
Review comment:
Thanks for your contribution~
Could you add a test for this, like the one you described in jira?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services