You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/05/28 17:12:23 UTC

Review Request 34770: Ranger: Admin RU does not complete for HDP-2.2 -> HDP-2.3

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34770/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Selvamohan Neethiraj.


Bugs: AMBARI-11483
    https://issues.apache.org/jira/browse/AMBARI-11483


Repository: ambari


Description
-------

* Changes for Ranger Admin & Usersync.  Worked closely with Ranger team
* Small changes to hdfs and hbase plugins to use the correct directory during RU.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py e9ec4f5 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java PRE-CREATION 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 30198c9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 882b982 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 86049f8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 923d9df 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py f7ddbed 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py f5da743 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 2c7a599 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 6e32dac 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py df85da8 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 1cbdd88 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/34770/diff/


Testing
-------

----------------------------------------------------------------------
Ran 235 tests in 6.915s

OK
----------------------------------------------------------------------
Total run:744
Total errors:0
Total failures:0
OK

Tests run: 3012, Failures: 0, Errors: 0, Skipped: 21

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:45.414s
[INFO] Finished at: Thu May 28 11:10:21 EDT 2015
[INFO] Final Memory: 32M/1173M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 34770: Ranger: Admin RU does not complete for HDP-2.2 -> HDP-2.3

Posted by Nate Cole <nc...@hortonworks.com>.

> On May 28, 2015, 2:17 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java, lines 34-38
> > <https://reviews.apache.org/r/34770/diff/1/?file=973595#file973595line34>
> >
> >     Consider moving to a versioned directory?

When the next one comes along maybe.  For now, meh.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34770/#review85587
-----------------------------------------------------------


On May 28, 2015, 11:12 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34770/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 11:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Selvamohan Neethiraj.
> 
> 
> Bugs: AMBARI-11483
>     https://issues.apache.org/jira/browse/AMBARI-11483
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Changes for Ranger Admin & Usersync.  Worked closely with Ranger team
> * Small changes to hdfs and hbase plugins to use the correct directory during RU.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py e9ec4f5 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 30198c9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 882b982 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 86049f8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 923d9df 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py f7ddbed 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py f5da743 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 2c7a599 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 6e32dac 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py df85da8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 1cbdd88 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34770/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 235 tests in 6.915s
> 
> OK
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> Tests run: 3012, Failures: 0, Errors: 0, Skipped: 21
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:45.414s
> [INFO] Finished at: Thu May 28 11:10:21 EDT 2015
> [INFO] Final Memory: 32M/1173M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 34770: Ranger: Admin RU does not complete for HDP-2.2 -> HDP-2.3

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34770/#review85587
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java
<https://reviews.apache.org/r/34770/#comment137177>

    Consider moving to a versioned directory?


- Jonathan Hurley


On May 28, 2015, 11:12 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34770/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 11:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Selvamohan Neethiraj.
> 
> 
> Bugs: AMBARI-11483
>     https://issues.apache.org/jira/browse/AMBARI-11483
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Changes for Ranger Admin & Usersync.  Worked closely with Ranger team
> * Small changes to hdfs and hbase plugins to use the correct directory during RU.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py e9ec4f5 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 30198c9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 882b982 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 86049f8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 923d9df 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py f7ddbed 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py f5da743 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 2c7a599 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 6e32dac 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py df85da8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 1cbdd88 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34770/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 235 tests in 6.915s
> 
> OK
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> Tests run: 3012, Failures: 0, Errors: 0, Skipped: 21
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:45.414s
> [INFO] Finished at: Thu May 28 11:10:21 EDT 2015
> [INFO] Final Memory: 32M/1173M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 34770: Ranger: Admin RU does not complete for HDP-2.2 -> HDP-2.3

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34770/#review85597
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
<https://reviews.apache.org/r/34770/#comment137191>

    Think we will need to do this for hive/knox also.


- Gautam Borad


On May 28, 2015, 3:12 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34770/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 3:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Selvamohan Neethiraj.
> 
> 
> Bugs: AMBARI-11483
>     https://issues.apache.org/jira/browse/AMBARI-11483
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Changes for Ranger Admin & Usersync.  Worked closely with Ranger team
> * Small changes to hdfs and hbase plugins to use the correct directory during RU.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py e9ec4f5 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 30198c9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 882b982 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 86049f8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 923d9df 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py f7ddbed 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py f5da743 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 2c7a599 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 6e32dac 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py df85da8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 1cbdd88 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34770/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 235 tests in 6.915s
> 
> OK
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> Tests run: 3012, Failures: 0, Errors: 0, Skipped: 21
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:45.414s
> [INFO] Finished at: Thu May 28 11:10:21 EDT 2015
> [INFO] Final Memory: 32M/1173M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 34770: Ranger: Admin RU does not complete for HDP-2.2 -> HDP-2.3

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34770/#review85581
-----------------------------------------------------------

Ship it!


Wow, all this for Ranger!

- Alejandro Fernandez


On May 28, 2015, 3:12 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34770/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 3:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Selvamohan Neethiraj.
> 
> 
> Bugs: AMBARI-11483
>     https://issues.apache.org/jira/browse/AMBARI-11483
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Changes for Ranger Admin & Usersync.  Worked closely with Ranger team
> * Small changes to hdfs and hbase plugins to use the correct directory during RU.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py e9ec4f5 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 30198c9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 882b982 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 86049f8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 923d9df 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py f7ddbed 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py f5da743 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 2c7a599 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 6e32dac 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py df85da8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 1cbdd88 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34770/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 235 tests in 6.915s
> 
> OK
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> Tests run: 3012, Failures: 0, Errors: 0, Skipped: 21
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:45.414s
> [INFO] Finished at: Thu May 28 11:10:21 EDT 2015
> [INFO] Final Memory: 32M/1173M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>