You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2013/06/12 18:19:15 UTC
Re: Review Request: JMX support for Seq Generator Source
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11822/
-----------------------------------------------------------
(Updated June 12, 2013, 4:19 p.m.)
Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
Changes
-------
Adding flume group
Description
-------
Seq Generator Source supports following metrics:
START
STOP
EVENTS_ACCEPTED
APPEND_BATCH_ACCEPTED
This addresses bug FLUME-2082.
https://issues.apache.org/jira/browse/FLUME-2082
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 0f85e87
Diff: https://reviews.apache.org/r/11822/diff/
Testing
-------
Ran existing tests
Thanks,
Sravya Tirukkovalur
Re: Review Request: JMX support for Seq Generator Source
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On June 12, 2013, 4:44 p.m., Will McQueen wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java, line 50
> > <https://reviews.apache.org/r/11822/diff/1/?file=303993#file303993line50>
> >
> > redundant, will be 0 by default
Hi Will,
Thanks for reviewing the patch!
These lines of code are untouched in this patch. Is it still recommended to change it?
Thanks!
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11822/#review21803
-----------------------------------------------------------
On June 12, 2013, 4:19 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11822/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 4:19 p.m.)
>
>
> Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
>
>
> Description
> -------
>
> Seq Generator Source supports following metrics:
> START
> STOP
> EVENTS_ACCEPTED
> APPEND_BATCH_ACCEPTED
>
>
> This addresses bug FLUME-2082.
> https://issues.apache.org/jira/browse/FLUME-2082
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 0f85e87
>
> Diff: https://reviews.apache.org/r/11822/diff/
>
>
> Testing
> -------
>
> Ran existing tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request: JMX support for Seq Generator Source
Posted by Will McQueen <wi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11822/#review21803
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
<https://reviews.apache.org/r/11822/#comment44983>
redundant, will be 0 by default
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
<https://reviews.apache.org/r/11822/#comment44982>
redundant, will be 0 by default
- Will McQueen
On June 12, 2013, 4:19 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11822/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 4:19 p.m.)
>
>
> Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
>
>
> Description
> -------
>
> Seq Generator Source supports following metrics:
> START
> STOP
> EVENTS_ACCEPTED
> APPEND_BATCH_ACCEPTED
>
>
> This addresses bug FLUME-2082.
> https://issues.apache.org/jira/browse/FLUME-2082
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 0f85e87
>
> Diff: https://reviews.apache.org/r/11822/diff/
>
>
> Testing
> -------
>
> Ran existing tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request: JMX support for Seq Generator Source
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11822/#review22268
-----------------------------------------------------------
Ship it!
+1, looks good to me and the unit tests pass. Personally I'm happy with a patch that only has the minimal changes required. I'm removing the unused import on commit.
- Mike Percy
On June 12, 2013, 4:19 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11822/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 4:19 p.m.)
>
>
> Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
>
>
> Description
> -------
>
> Seq Generator Source supports following metrics:
> START
> STOP
> EVENTS_ACCEPTED
> APPEND_BATCH_ACCEPTED
>
>
> This addresses bug FLUME-2082.
> https://issues.apache.org/jira/browse/FLUME-2082
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 0f85e87
>
> Diff: https://reviews.apache.org/r/11822/diff/
>
>
> Testing
> -------
>
> Ran existing tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>