You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Jesse MacFadyen (JIRA)" <ji...@apache.org> on 2012/07/17 00:14:34 UTC

[jira] [Created] (CB-1079) Remove Named Args

Jesse MacFadyen created CB-1079:
-----------------------------------

             Summary: Remove Named Args
                 Key: CB-1079
                 URL: https://issues.apache.org/jira/browse/CB-1079
             Project: Apache Cordova
          Issue Type: Bug
          Components: CordovaJS, WP7
    Affects Versions: 1.9.0
            Reporter: Jesse MacFadyen
            Assignee: Jesse MacFadyen


The following list is everywhere that the native side is using JSON DataContract serialization. Change these methods to expect an array of values instead of the current namedArguments.

Commands\Camera.cs(199): new CameraOptions() : JSON.JsonHelper.Deserialize<CameraOptions>(options);
Commands\Capture.cs(248): CaptureImageOptions.Default : JSON.JsonHelper.Deserialize<CaptureImageOptions>(options);
Commands\Capture.cs(279): CaptureAudioOptions.Default : JSON.JsonHelper.Deserialize<CaptureAudioOptions>(options);
Commands\Capture.cs(310): CaptureVideoOptions.Default : JSON.JsonHelper.Deserialize<CaptureVideoOptions>(options);
Commands\Capture.cs(347): mediaFormatOptions = JSON.JsonHelper.Deserialize<MediaFormatOptions>(options);
Commands\Capture.cs(406): file = String.IsNullOrEmpty(options) ? null : JSON.JsonHelper.Deserialize<MediaFile>(options);
Commands\Compass.cs(264): compassOptions = JSON.JsonHelper.Deserialize<CompassOptions>(options);
Commands\Compass.cs(299): compassOptions = JSON.JsonHelper.Deserialize<CompassOptions>(options);
Commands\Contacts.cs(200): JSONContact contact = JSON.JsonHelper.Deserialize<JSONContact>(jsonContact);
Commands\Contacts.cs(375): ContactSearchParams searchParams = JSON.JsonHelper.Deserialize<ContactSearchParams>(searchCriteria);
Commands\File.cs(430): fileOptions = JSON.JsonHelper.Deserialize<FileOptions>(options);
Commands\FileTransfer.cs(254): uploadOptions = JSON.JsonHelper.Deserialize<UploadOptions>(options);
Commands\FileTransfer.cs(290): downloadOptions = JSON.JsonHelper.Deserialize<DownloadOptions>(options);
Commands\Media.cs(69): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(115): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(159): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(200): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(231): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(284): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(330): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(373): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(421): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Media.cs(461): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
Commands\Notification.cs(92): AlertOptions alertOpts = JSON.JsonHelper.Deserialize<AlertOptions>(options);
Commands\Notification.cs(123): AlertOptions alertOpts = JSON.JsonHelper.Deserialize<AlertOptions>(options);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CB-1079) Remove Named Args

Posted by "Jesse MacFadyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse MacFadyen resolved CB-1079.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0

https://github.com/purplecabbage/incubator-cordova-js/tree/5b628257cf3420b7c4c3417afcefc388113e35e4
                
> Remove Named Args
> -----------------
>
>                 Key: CB-1079
>                 URL: https://issues.apache.org/jira/browse/CB-1079
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS, WP7
>    Affects Versions: 1.9.0
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>             Fix For: 2.0.0
>
>
> The following list is everywhere that the native side is using JSON DataContract serialization. Change these methods to expect an array of values instead of the current namedArguments.
> Commands\Camera.cs(199): new CameraOptions() : JSON.JsonHelper.Deserialize<CameraOptions>(options);
> Commands\Capture.cs(248): CaptureImageOptions.Default : JSON.JsonHelper.Deserialize<CaptureImageOptions>(options);
> Commands\Capture.cs(279): CaptureAudioOptions.Default : JSON.JsonHelper.Deserialize<CaptureAudioOptions>(options);
> Commands\Capture.cs(310): CaptureVideoOptions.Default : JSON.JsonHelper.Deserialize<CaptureVideoOptions>(options);
> Commands\Capture.cs(347): mediaFormatOptions = JSON.JsonHelper.Deserialize<MediaFormatOptions>(options);
> Commands\Capture.cs(406): file = String.IsNullOrEmpty(options) ? null : JSON.JsonHelper.Deserialize<MediaFile>(options);
> Commands\Compass.cs(264): compassOptions = JSON.JsonHelper.Deserialize<CompassOptions>(options);
> Commands\Compass.cs(299): compassOptions = JSON.JsonHelper.Deserialize<CompassOptions>(options);
> Commands\Contacts.cs(200): JSONContact contact = JSON.JsonHelper.Deserialize<JSONContact>(jsonContact);
> Commands\Contacts.cs(375): ContactSearchParams searchParams = JSON.JsonHelper.Deserialize<ContactSearchParams>(searchCriteria);
> Commands\File.cs(430): fileOptions = JSON.JsonHelper.Deserialize<FileOptions>(options);
> Commands\FileTransfer.cs(254): uploadOptions = JSON.JsonHelper.Deserialize<UploadOptions>(options);
> Commands\FileTransfer.cs(290): downloadOptions = JSON.JsonHelper.Deserialize<DownloadOptions>(options);
> Commands\Media.cs(69): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(115): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(159): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(200): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(231): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(284): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(330): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(373): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(421): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Media.cs(461): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
> Commands\Notification.cs(92): AlertOptions alertOpts = JSON.JsonHelper.Deserialize<AlertOptions>(options);
> Commands\Notification.cs(123): AlertOptions alertOpts = JSON.JsonHelper.Deserialize<AlertOptions>(options);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira