You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rhtyd <gi...@git.apache.org> on 2016/06/28 10:36:24 UTC
[GitHub] cloudstack pull request #1599: Independent marvin
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1599
Independent marvin
The aim is to make marvin independent of CloudStack. I had started this work few months ago, but recently resumed it after working on Trillian.
- The aim is to show that marvin can exist as a standalone library: https://github.com/rhtyd/marvin
- Travis, Trillian and other test/build systems can use the library from git repo, or pip etc. and then use it to generate `cloudstackAPI` at runtime and then launch tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack independent-marvin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1599
----
commit 6af0e62b87a041e77938f91d9a6b7bb29bc640b7
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-06-28T10:23:20Z
marvin: fix codegeneration against API discovery endpoint
This makes the commands.xml based codegeneration equivalent to the
API discovery end point based discovery.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit 6dc7081f627d9fda9d87d6e0c9a92b4b53c17046
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-06-28T10:33:33Z
travis: use codegenerated marvin at runtime
This uses marvin with auto-generated APIs against a running mgmt server, instead
of marvin with APIs bundled at build-time.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd that explanation makes sense, and the code seems to address that issue. Could you please amend the explanation to the commit message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Due to changes in marvin, specifically the code generator that runs during build-time and is not used with either Travis or otherwise, manual tests have confirmed the functionality working. With enough reviews, I'll merge this. Thanks all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@jburwell the Travis build failed due to tearDown error in one of the tests:
=== TestName: test_listVM_by_id_as_user_vmsfromotherdomain | Status : EXCEPTION ===
I'll re-kick it. The PR does not change any part of CloudStack, nor are the changes in the normal codegenerator used to generate `cloudstackAPI` in the marvin library.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Independent marvin
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@wido yes, with this PR we can split marvin to its own repository. As an example to show it's doable, here is a repository I extracted from cloudstack master -- https://github.com/rhtyd/marvin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@jburwell yes, this PR does not implement API-discovery based generation but rather fixes the fields that the (api discovery based) codegenerator should produce in the generated python classes (cmd and response classes per api/module). The issue was the autogenerated `cloudstackAPI` differed between api-based and apidocs-based code generation. With this PR the generated classes match exactly thereby allowing us to go with either methods to generate `cloudstackAPI`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by rhtyd <gi...@git.apache.org>.
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1599
Marvin: Fix codegenerator to work with API discovery
This fixes Marvin cloudstackAPI generator to work with a live running mgmt server's api discovery.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack independent-marvin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1599
----
commit b2ce02dbf8ca6ffe5220bea933d6e34f4612e6f9
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-06-28T10:23:20Z
marvin: fix codegeneration against API discovery endpoint
This makes the commands.xml based codegeneration equivalent to the
API discovery end point based discovery.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
The initiative to split marvin into its own repository has been dropped for now. Meanwhile, this PR can still be accepted as it fixed the code-generator to work against the api discovery. I'll send another PR that will add marvin and integration test as a separate rpm/deb package.
/cc @swill @syed @bvbharat @resmo @PaulAngus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Independent marvin
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1599
This is just there to get the ground work done for Marvin to it's own repo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1599
The code seams to make sense. I like the idea of api auto-discovery so it's a LGTM I guest.
I'm a bit out of context on this one but if it's usefull lets merge it.
Cheers,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by rhtyd <gi...@git.apache.org>.
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1599
Marvin: Fix codegenerator to work with API discovery
This fixes Marvin cloudstackAPI generator to work with a live running mgmt server's api discovery.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack independent-marvin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1599
----
commit b2ce02dbf8ca6ffe5220bea933d6e34f4612e6f9
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-06-28T10:23:20Z
marvin: fix codegeneration against API discovery endpoint
This makes the commands.xml based codegeneration equivalent to the
API discovery end point based discovery.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Packaging result: \u2714centos6 \u2714centos7 \u2714debian repo: http://packages.shapeblue.com/cloudstack/pr/1599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Pinging for review - @wido @koushik-das @karuturi @abhinandanprateek @jburwell
This enables `cloudstackAPI` api cmd/resp classes generation against a live running mgmt server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd Is my understanding correct that auto discovery was implemented in a previous commit and this PR fixes an defect in that work? If so, could you please provide a detailed explanation of the issue fixed by this commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by rhtyd <gi...@git.apache.org>.
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1599
Marvin: Fix codegenerator to work with API discovery
This fixes Marvin cloudstackAPI generator to work with a live running mgmt server's api discovery.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack independent-marvin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1599
----
commit b2ce02dbf8ca6ffe5220bea933d6e34f4612e6f9
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-06-28T10:23:20Z
marvin: fix codegeneration against API discovery endpoint
This makes the commands.xml based codegeneration equivalent to the
API discovery end point based discovery.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Independent marvin
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Understood. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@jburwell fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd thanks for the expanded commit message. The change makes complete sense to me now. LGTM for code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Pinging for review -- @karuturi @jburwell @koushik-das @swill @pdion891 and others. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1599: Independent marvin
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
/cc @swill @jburwell @abhinandanprateek @murali-reddy @DaanHoogland @wido
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---