You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "t-rana (via GitHub)" <gi...@apache.org> on 2024/10/17 17:47:04 UTC
[PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
t-rana opened a new pull request, #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "t-rana (via GitHub)" <gi...@apache.org>.
t-rana commented on PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807#issuecomment-2421307425
@rishabhdaim
I have raised another PR for adding util, once that is merged, I will move this to review again.
https://github.com/apache/jackrabbit-oak/pull/1808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "t-rana (via GitHub)" <gi...@apache.org>.
t-rana commented on PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807#issuecomment-2421512230
@rishabhdaim
I was waiting for my other PR (https://github.com/apache/jackrabbit-oak/pull/1808) to get merged. Now that is merged, and I have updated this one accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807#issuecomment-2421289643
@t-rana could you please split the PR into 2 parts i.e. one for creating a Utility and the other which uses that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "t-rana (via GitHub)" <gi...@apache.org>.
t-rana commented on code in PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807#discussion_r1806161171
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/collections/CollectionUtils.java:
##########
@@ -171,7 +171,6 @@ public static <T> Set<T> toSet(@NotNull final Iterator<T> iterator) {
iterator.forEachRemaining(result::add);
return result;
}
-
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807#issuecomment-2421401378
@t-rana you need to remove the utils related changes from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11206: remove usage of Queues.newArrayDeque [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1807:
URL: https://github.com/apache/jackrabbit-oak/pull/1807#discussion_r1806120392
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/collections/CollectionUtils.java:
##########
@@ -171,7 +171,6 @@ public static <T> Set<T> toSet(@NotNull final Iterator<T> iterator) {
iterator.forEachRemaining(result::add);
return result;
}
-
Review Comment:
please remove this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org