You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by AviaE <gi...@git.apache.org> on 2017/05/10 15:15:37 UTC
[GitHub] incubator-ariatosca pull request #131: ARIA-157 Failing CLI service-template...
GitHub user AviaE opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/131
ARIA-157 Failing CLI service-templates store tests on Windows
Three tests from `aria service-templates store` failed on Windows, but
not on Linux.
The reason for this failures was differing implementation of
os.path.dirname across the platforms.
Python implements os.path.dirname in the ntpath module. There, somewhere
down the line of calls, (a part of) the argument of dirname is tested
for membership in a string (using `in`). In these three tests, the
argument of dirname is of type MagicMock, and an error is raised since
only a string can be tested for membership in a string.
The solution was to mock the dirname calls.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-ariatosca ARIA-157-cli-service-template-store-tests-fail-in-windows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit 6864d42e1748b5cd8ecc596fc1b4adc04b0cc9ba
Author: Avia Efrat <av...@gigaspaces.com>
Date: 2017-05-10T14:39:49Z
ARIA-157 Failing CLI service-templates store tests on Windows
Three tests from `aria service-templates store` failed on Windows, but
not on Linux.
The reason for this failures was differing implementation of
os.path.dirname across the platforms.
Python implements os.path.dirname in the ntpath module. There, somewhere
down the line of calls, (a part of) the argument of dirname is tested
for membership in a string (using `in`). In these three tests, the
argument of dirname is of type MagicMock, and an error is raised since
only a string can be tested for membership in a string.
The solution was to mock the dirname calls.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #131: ARIA-157 Failing CLI service-template...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-ariatosca/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---