[jira] [Work logged] (HIVE-25898) Compaction txn heartbeating after Worker timeout

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25898?focusedWorklogId=716400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716400 ]

ASF GitHub Bot logged work on HIVE-25898:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/22 12:56
            Start Date: 27/Jan/22 12:56
    Worklog Time Spent: 10m 
      Work Description: veghlaci05 opened a new pull request #2981:
URL: https://github.com/apache/hive/pull/2981


   ### What changes were proposed in this pull request?
   
   This PR fixes the issue when the Heartbeater of the CompactionTxn is not shut down. This could happen if an exception is thrown from CompactionTxn.abort() or CompactionTxn.commit() which is not caught by the catch block. The fix reworks heartbeat handling the following way:
   1. The heartbeater is shut down BEFORE calling abort() or commit(), so regardless of the outcome of the transaction, or if an exception is thrown or not, the heartbeater won't stay alive. Another benefit that, this approach solves the logging after commit()/abort() issue too, without the need of the previously introduced additional logic (See: HIVE-25740).
   
   ### Why are the changes needed?
   To fix the issue that in some cases the heartbeater of a CompactionTxn is not shut down properly.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   
   Through unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 716400)
    Remaining Estimate: 0h
            Time Spent: 10m

> Compaction txn heartbeating after Worker timeout
> ------------------------------------------------
>
>                 Key: HIVE-25898
>                 URL: https://issues.apache.org/jira/browse/HIVE-25898
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: László Végh
>            Assignee: László Végh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In some cases, when the compaction transaction is aborted, the hearbeater thread is not shut down and keeps heartbeating.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)