You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2023/06/28 11:56:25 UTC

[doris] branch master updated: [bugfix](recover) do not need dynamic partition recover except olap table (#21290)

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 325504deeb [bugfix](recover) do not need dynamic partition recover except olap table (#21290)
325504deeb is described below

commit 325504deebf21e1fc3fb80be828ae85fdfcff43c
Author: yiguolei <67...@qq.com>
AuthorDate: Wed Jun 28 19:56:17 2023 +0800

    [bugfix](recover) do not need dynamic partition recover except olap table (#21290)
    
    introduced by #19031
    
    FE could not recover any more because there is a convert to olap table operation in the code. But there are many table types that is not a olap table such as view jdbc table ...
    It will convert failed and FE will not start correctly.Co-authored-by: yiguolei <yi...@gmail.com>
---
 .../src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java    | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java
index d05e61ff01..e6e8850a9a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java
@@ -697,7 +697,10 @@ public class CatalogRecycleBin extends MasterDaemon implements Writable {
                 RecoverInfo recoverInfo = new RecoverInfo(db.getId(), table.getId(), -1L, "", newTableName, "");
                 Env.getCurrentEnv().getEditLog().logRecoverTable(recoverInfo);
             }
-            DynamicPartitionUtil.registerOrRemoveDynamicPartitionTable(db.getId(), (OlapTable) table, isReplay);
+            // Only olap table need recover dynamic partition, other table like jdbc odbc view.. do not need it
+            if (table.getType() == TableType.OLAP) {
+                DynamicPartitionUtil.registerOrRemoveDynamicPartitionTable(db.getId(), (OlapTable) table, isReplay);
+            }
         } finally {
             table.writeUnlock();
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org