You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/24 20:14:48 UTC

[GitHub] [airflow] kaxil commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

kaxil commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables
URL: https://github.com/apache/airflow/pull/4991#issuecomment-495775152
 
 
   LGTM but we should also update the code in `varimport` in `views.py`
   
   otherwise the CLI behaves differently than the UI. As @mik-laj pointed out, our end goal is to have 1 code and use it in CLI & UI. That is out of scope of this PR but lets update the change in UI too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services