You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/09 02:04:00 UTC
[GitHub] [incubator-inlong] leosanqing opened a new pull request, #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
leosanqing opened a new pull request, #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605
### Prepare a Pull Request
- Fixes #4576
### Motivation
It's time to upgrade Junit version ,It provides more functions
### Modifications
- Manager unit-tests
- Maven dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leosanqing commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
leosanqing commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r894592714
##########
inlong-manager/manager-client/src/test/java/org/apache/inlong/manager/client/api/inner/InnerInlongManagerClientTest.java:
##########
@@ -86,11 +86,11 @@ class InnerInlongManagerClientTest {
@BeforeAll
static void setup() {
- wireMockServer = new WireMockServer(options().port(8084));
+ wireMockServer = new WireMockServer(options().port(8484));
Review Comment:
This port has been used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r894108643
##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/AutoPush2HiveExample.java:
##########
@@ -29,18 +29,20 @@
import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
import org.apache.inlong.manager.common.pojo.stream.StreamField;
import org.apache.shiro.util.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
import java.util.List;
import java.util.concurrent.TimeUnit;
/**
* Test class for auto push to hive.
*/
-public class AutoPush2HiveExample extends BaseExample {
+@Disabled
+class AutoPush2HiveExample extends BaseExample {
@Test
Review Comment:
If this is not the unit test class, suggest removing all `@Test` annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leosanqing commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
leosanqing commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r894592966
##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/AutoPush2HiveExample.java:
##########
@@ -29,18 +29,20 @@
import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
import org.apache.inlong.manager.common.pojo.stream.StreamField;
import org.apache.shiro.util.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
import java.util.List;
import java.util.concurrent.TimeUnit;
/**
* Test class for auto push to hive.
*/
-public class AutoPush2HiveExample extends BaseExample {
+@Disabled
+class AutoPush2HiveExample extends BaseExample {
@Test
Review Comment:
This port has been used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace Junit4
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r897498435
##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/Kafka2HiveExample.java:
##########
@@ -39,14 +40,15 @@
* Test class for kafka to hive.
*/
@Slf4j
+@Disabled
public class Kafka2HiveExample extends BaseExample {
@Test
public void testCreateGroupForHive() {
ClientConfiguration configuration = new ClientConfiguration();
- configuration.setWriteTimeout(10);
- configuration.setReadTimeout(10);
- configuration.setConnectTimeout(10);
+ configuration.setWriteTimeout(1000);
Review Comment:
Why increase those timeouts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leosanqing closed pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
leosanqing closed pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
URL: https://github.com/apache/incubator-inlong/pull/4605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leosanqing commented on pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
leosanqing commented on PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#issuecomment-1150599848
The current branch has code unrelated to the Junit upgrade, which will be corrected later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r897482216
##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/AutoPush2HiveExample.java:
##########
@@ -29,18 +29,20 @@
import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
import org.apache.inlong.manager.common.pojo.stream.StreamField;
import org.apache.shiro.util.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
import java.util.List;
import java.util.concurrent.TimeUnit;
/**
* Test class for auto push to hive.
*/
-public class AutoPush2HiveExample extends BaseExample {
+@Disabled
+class AutoPush2HiveExample extends BaseExample {
@Test
Review Comment:
OK, good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leosanqing commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
leosanqing commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r894596726
##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/AutoPush2HiveExample.java:
##########
@@ -29,18 +29,20 @@
import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
import org.apache.inlong.manager.common.pojo.stream.StreamField;
import org.apache.shiro.util.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
import java.util.List;
import java.util.concurrent.TimeUnit;
/**
* Test class for auto push to hive.
*/
-public class AutoPush2HiveExample extends BaseExample {
+@Disabled
+class AutoPush2HiveExample extends BaseExample {
@Test
Review Comment:
This is to deal with the unit test in the real environment.
If it is removed, we have to use the main method to create the corresponding example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace junit4
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605#discussion_r894108245
##########
inlong-manager/manager-client/src/test/java/org/apache/inlong/manager/client/api/inner/InnerInlongManagerClientTest.java:
##########
@@ -86,11 +86,11 @@ class InnerInlongManagerClientTest {
@BeforeAll
static void setup() {
- wireMockServer = new WireMockServer(options().port(8084));
+ wireMockServer = new WireMockServer(options().port(8484));
Review Comment:
Why change the port?
##########
inlong-manager/manager-client/src/test/java/org/apache/inlong/manager/client/api/inner/InnerInlongManagerClientTest.java:
##########
@@ -86,11 +86,11 @@ class InnerInlongManagerClientTest {
@BeforeAll
static void setup() {
- wireMockServer = new WireMockServer(options().port(8084));
+ wireMockServer = new WireMockServer(options().port(8484));
Review Comment:
Why change the port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4605: [INLONG-4576][Manager] Use Junit5(Jupiter) to replace Junit4
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4605:
URL: https://github.com/apache/incubator-inlong/pull/4605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org