You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Ari Rabkin (JIRA)" <ji...@apache.org> on 2009/01/08 10:42:59 UTC
[jira] Created: (HADOOP-4993) chukwa agent startup should be more
modular
chukwa agent startup should be more modular
-------------------------------------------
Key: HADOOP-4993
URL: https://issues.apache.org/jira/browse/HADOOP-4993
Project: Hadoop Core
Issue Type: Bug
Components: contrib/chukwa
Reporter: Ari Rabkin
Assignee: Ari Rabkin
Right now, the Chukwa Agent configuration and startup code is complex and tangled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4993) chukwa agent startup should be more
modular
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661912#action_12661912 ]
Ari Rabkin commented on HADOOP-4993:
------------------------------------
It's hard to write unit tests for ChukwaAgent, because there's no way to suppress the default configuration mechanism and pass the Agent a hardcoded test configuration. I think the fix is to create another constructor, that takes a Configuration explicitly instead of reading a file. This will make it easy to test the configuration and startup mechanisms. Those tests should probably appeaer with this JIRA.
And as long as we're fixing the configuration mechanism, we shouldn't read both initial_adaptors and a checkpoint. Initial_adaptors should only be used if there isn't a checkpoint.
> chukwa agent startup should be more modular
> -------------------------------------------
>
> Key: HADOOP-4993
> URL: https://issues.apache.org/jira/browse/HADOOP-4993
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
>
> Right now, the Chukwa Agent configuration and startup code is complex and tangled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4993) chukwa agent startup should be more
modular
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663537#action_12663537 ]
Eric Yang commented on HADOOP-4993:
-----------------------------------
Chukwa Configuration is much easier to use with this patch. +1
> chukwa agent startup should be more modular
> -------------------------------------------
>
> Key: HADOOP-4993
> URL: https://issues.apache.org/jira/browse/HADOOP-4993
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Attachments: agentconfig.patch
>
>
> Right now, the Chukwa Agent configuration and startup code is complex and tangled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4993) chukwa agent startup should be more
modular
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated HADOOP-4993:
-------------------------------
Status: Patch Available (was: Open)
> chukwa agent startup should be more modular
> -------------------------------------------
>
> Key: HADOOP-4993
> URL: https://issues.apache.org/jira/browse/HADOOP-4993
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Attachments: agentconfig.patch
>
>
> Right now, the Chukwa Agent configuration and startup code is complex and tangled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4993) chukwa agent startup should be more
modular
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated HADOOP-4993:
-------------------------------
Attachment: agentconfig.patch
patch to fix issue. A previous patch clobbered case-sensitivity for Add commands. This patch restores that. (It's a six character fix, included here to make the test work properly.)
> chukwa agent startup should be more modular
> -------------------------------------------
>
> Key: HADOOP-4993
> URL: https://issues.apache.org/jira/browse/HADOOP-4993
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Attachments: agentconfig.patch
>
>
> Right now, the Chukwa Agent configuration and startup code is complex and tangled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4993) chukwa agent startup should be more
modular
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4993:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this. Thanks, Ari
> chukwa agent startup should be more modular
> -------------------------------------------
>
> Key: HADOOP-4993
> URL: https://issues.apache.org/jira/browse/HADOOP-4993
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Fix For: 0.20.0
>
> Attachments: agentconfig.patch
>
>
> Right now, the Chukwa Agent configuration and startup code is complex and tangled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.