You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/06/22 01:39:23 UTC

[GitHub] [lucene] dnhatn opened a new pull request #192: Make DocValuesIterator class public

dnhatn opened a new pull request #192:
URL: https://github.com/apache/lucene/pull/192


   This change makes DocValuesIterator public so we use the `advanceExact()` method on a "generic" doc values iterator. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dsmiley commented on pull request #192: Make DocValuesIterator class public

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-865475628


   This has come up not just once but twice.  Even then I suspect maybe a third might be somewhere ;-)
   https://issues.apache.org/jira/browse/LUCENE-9203
   Discuss in JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dsmiley commented on pull request #192: Make DocValuesIterator class public

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-865475628


   This has come up not just once but twice.  Even then I suspect maybe a third might be somewhere ;-)
   https://issues.apache.org/jira/browse/LUCENE-9203
   Discuss in JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dnhatn closed pull request #192: Make DocValuesIterator class public

Posted by GitBox <gi...@apache.org>.
dnhatn closed pull request #192:
URL: https://github.com/apache/lucene/pull/192


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] rmuir commented on pull request #192: Make DocValuesIterator class public

Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-865739432


   and similar to those previous 2 times, where it turned out to be a bad idea, i think it might be here too. why is this method needed? if we expose it, it will make it harder to switch docvalues to use block-level postings-like compression (see recent dev discussions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dnhatn commented on pull request #192: Make DocValuesIterator class public

Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-866107179


   Sorry, I didn't search for the existing issues before opening this PR. My need is a stronger upper type bound than DocIdSetIterator for docValues iterators. I am okay to close this PR if it prevents future optimizations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org