[GitHub] [airflow] potiuk commented on a change in pull request #5620: [AIRFLOW-4997] Support for non-master branches

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #5620: [AIRFLOW-4997] Support for non-master branches
URL: https://github.com/apache/airflow/pull/5620#discussion_r305884195
 
 

 ##########
 File path: hooks/build
 ##########
 @@ -155,10 +156,22 @@ export DOCKERHUB_REPO=${DOCKERHUB_REPO:="airflow"}
 export PYTHON_VERSION=\
 ${PYTHON_VERSION:=$(python -c 'import sys;print("%s.%s" % (sys.version_info.major, sys.version_info.minor))')}
 
+. ${MY_DIR}/_default_branch.sh
+
+# Source brnnch will be set in DockerHub
+SOURCE_BRANCH=${SOURCE_BRANCH:=${DEFAULT_BRANCH}}
+# if AIRFLOW_CONTAINER_BRANCH_NAME is not set it will be set to either SOURCE_BRANCH (if set in DockerHub
+# or default branch configured in _default_branch.sh
+AIRFLOW_CONTAINER_BRANCH_NAME=${AIRFLOW_CONTAINER_BRANCH_NAME:=${SOURCE_BRANCH}}
 
 Review comment:
   Not really. Stable branch is usually only built on Travis CI not for local developer builds. 
   
   We usually work in the way that we make v1-10-test branch work locally  (where DEFAULT_BRANCH=v1-10-test is fine). And then we move stable branch up when v1-10-test branch is green. Then in effect stable branch is only run on Travis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services