You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/09 22:17:29 UTC

Review Request 36367: DB cron job store: allow upsert.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36367/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1390
    https://issues.apache.org/jira/browse/AURORA-1390


Repository: aurora


Description
-------

DB cron job store: allow upsert.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/storage/db/CronJobMapper.java a2727857fdd0c3f4d81b5e2550bc48eec026c3ed 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java c2696a90e98ad5ecc2eb2e8794e225d2c2779046 
  src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 936c2b8b2215506a147dcd8baebbc98bd424db69 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 6b9eb3468f1e6714831f9c7982c1e6b27051d3b8 

Diff: https://reviews.apache.org/r/36367/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 36367: DB cron job store: allow upsert.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36367/#review91189
-----------------------------------------------------------

Ship it!


Master (e996ca5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 9, 2015, 8:17 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36367/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 8:17 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1390
>     https://issues.apache.org/jira/browse/AURORA-1390
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> DB cron job store: allow upsert.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/CronJobMapper.java a2727857fdd0c3f4d81b5e2550bc48eec026c3ed 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java c2696a90e98ad5ecc2eb2e8794e225d2c2779046 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 936c2b8b2215506a147dcd8baebbc98bd424db69 
>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 6b9eb3468f1e6714831f9c7982c1e6b27051d3b8 
> 
> Diff: https://reviews.apache.org/r/36367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 36367: DB cron job store: allow upsert.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36367/#review91181
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On July 9, 2015, 1:17 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36367/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 1:17 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1390
>     https://issues.apache.org/jira/browse/AURORA-1390
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> DB cron job store: allow upsert.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/CronJobMapper.java a2727857fdd0c3f4d81b5e2550bc48eec026c3ed 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java c2696a90e98ad5ecc2eb2e8794e225d2c2779046 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 936c2b8b2215506a147dcd8baebbc98bd424db69 
>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 6b9eb3468f1e6714831f9c7982c1e6b27051d3b8 
> 
> Diff: https://reviews.apache.org/r/36367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>