You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2019/01/07 20:34:00 UTC

[arrow] branch master updated: ARROW-4125: [Python] Don't fail ASV if Plasma extension is not built (e.g. on Windows)

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new b92b1f5  ARROW-4125: [Python] Don't fail ASV if Plasma extension is not built (e.g. on Windows)
b92b1f5 is described below

commit b92b1f5b08a64004c8b35db24a34ac71de7bd0e3
Author: Wes McKinney <we...@apache.org>
AuthorDate: Mon Jan 7 14:33:51 2019 -0600

    ARROW-4125: [Python] Don't fail ASV if Plasma extension is not built (e.g. on Windows)
    
    I would guess I'm the first person to try to run the benchmark suite on Windows!
    
    Author: Wes McKinney <we...@apache.org>
    
    Closes #3271 from wesm/benchmark-no-plasma and squashes the following commits:
    
    c99b76fae <Wes McKinney> flake
    c7ede9fd4 <Wes McKinney> Revert whitespace change
    4938932d2 <Wes McKinney> Check for ImportError in benchmarks/plasma.py
    008ae7b98 <Wes McKinney> Don't fail ASV if Plasma extension is not built (e.g. on Windows)
---
 python/benchmarks/plasma.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/python/benchmarks/plasma.py b/python/benchmarks/plasma.py
index 398ec72..90a2845 100644
--- a/python/benchmarks/plasma.py
+++ b/python/benchmarks/plasma.py
@@ -18,7 +18,12 @@
 import numpy as np
 import timeit
 
-import pyarrow.plasma as plasma
+try:
+    import pyarrow.plasma as plasma
+except ImportError:
+    # TODO(wesm): These are not asv benchmarks, so we can just fail
+    # silently here
+    pass
 
 
 class SimplePlasmaThroughput(object):