You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SzyWilliam (via GitHub)" <gi...@apache.org> on 2025/04/03 07:16:56 UTC
[PR] [RTO/RPO] Coordinator/Session Failover Retry [iotdb]
SzyWilliam opened a new pull request, #15269:
URL: https://github.com/apache/iotdb/pull/15269
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [RTO/RPO] Coordinator/Session Failover Retry [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #15269:
URL: https://github.com/apache/iotdb/pull/15269#discussion_r2050488639
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/schematree/DeviceSchemaInfo.java:
##########
@@ -56,6 +56,16 @@ public PartialPath getDevicePath() {
return devicePath;
}
+ public String getAbbrString() {
Review Comment:
@Caideyipi Do we need this?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FailedFragmentInstance.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.plan.scheduler;
+
+import org.apache.iotdb.common.rpc.thrift.TSStatus;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.FragmentInstance;
+
+public class FailedFragmentInstance {
Review Comment:
remove to FailedFragmentInstanceWithTSStatus?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java:
##########
@@ -97,30 +98,33 @@ public class FragmentInstanceDispatcherImpl implements IFragInstanceDispatcher {
private static final String UNEXPECTED_ERRORS = "Unexpected errors: ";
+ private final long maxRetryDurationInNs;
+
public FragmentInstanceDispatcherImpl(
QueryType type,
MPPQueryContext queryContext,
ExecutorService executor,
Review Comment:
remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [RTO/RPO] Coordinator/Session Failover Retry [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #15269:
URL: https://github.com/apache/iotdb/pull/15269#discussion_r2045923805
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/AsyncPlanNodeSender.java:
##########
@@ -109,32 +109,36 @@ public void waitUntilCompleted() throws InterruptedException {
}
}
- public List<TSStatus> getFailureStatusList() {
- List<TSStatus> failureStatusList = new ArrayList<>();
+ public List<FailedFragmentInstance> getFailedInstances() {
+ List<FailedFragmentInstance> failureStatusList = new ArrayList<>();
Review Comment:
Better rename the variable
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java:
##########
@@ -97,30 +98,33 @@ public class FragmentInstanceDispatcherImpl implements IFragInstanceDispatcher {
private static final String UNEXPECTED_ERRORS = "Unexpected errors: ";
+ private final long maxRetryDurationInNs;
+
public FragmentInstanceDispatcherImpl(
QueryType type,
MPPQueryContext queryContext,
ExecutorService executor,
Review Comment:
Can this be deleted too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [RTO/RPO] Coordinator/Session Failover Retry [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #15269:
URL: https://github.com/apache/iotdb/pull/15269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org