You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/11/21 10:58:38 UTC
[GitHub] [struts] lukaszlenart opened a new pull request #450: [WW-3730] Avoids conversion to String[] of passed params
lukaszlenart opened a new pull request #450:
URL: https://github.com/apache/struts/pull/450
Fixes [WW-3730](https://issues.apache.org/jira/browse/WW-3730)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] yasserzamani merged pull request #450: [WW-3730] Avoids conversion to String[] of passed params
Posted by GitBox <gi...@apache.org>.
yasserzamani merged pull request #450:
URL: https://github.com/apache/struts/pull/450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] yasserzamani commented on pull request #450: [WW-3730] Avoids conversion to String[] of passed params
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on pull request #450:
URL: https://github.com/apache/struts/pull/450#issuecomment-731582791
Thanks! I found it :) Test has been changed through [WW-4572 Http parameters](https://github.com/apache/struts/pull/58) and I was watching original test. So basically yes then it's a breaking change, because the modified test doesn't try anymore that the value is always a `string[]` (The original test was doing via `((String[])params.get("foo"))[0]` which implicitly tests conversion to `string[]`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] yasserzamani commented on pull request #450: [WW-3730] Avoids conversion to String[] of passed params
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on pull request #450:
URL: https://github.com/apache/struts/pull/450#issuecomment-731573665
I wonder if it's a breaking change why still [this test](https://github.com/apache/struts/blob/a4793d27cf19546516167b1749e8d124c731e93a/core/src/test/java/org/apache/struts2/components/ActionComponentTest.java#L33) passes. Couldn't find why!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #450: [WW-3730] Avoids conversion to String[] of passed params
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #450:
URL: https://github.com/apache/struts/pull/450#issuecomment-731580463
Because everything is an Object right now, there is no conversion to String, which was not needed tbh. And it was potentially breaking change, maybe it isn't :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls commented on pull request #450: [WW-3730] Avoids conversion to String[] of passed params
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #450:
URL: https://github.com/apache/struts/pull/450#issuecomment-731565019
[](https://coveralls.io/builds/35143556)
Coverage decreased (-0.009%) to 49.779% when pulling **8996e0ad9733d7b95fc8f163d7df633cbe1221fa on WW-3730-use-params-directly** into **a4793d27cf19546516167b1749e8d124c731e93a on master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org