[GitHub] [samza] mynameborat commented on a diff in pull request #1640: SAMZA-2741: [Pipeline Drain] Fix ApplicationUtil.isHighLevelApiJob to work for anonymous and lambda `SamzaApplication` classes

[GitBox <gi...@apache.org>]

mynameborat commented on code in PR #1640:
URL: https://github.com/apache/samza/pull/1640#discussion_r1016065159


##########
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java:
##########
@@ -69,6 +69,8 @@ public static Runnable createRunLoop(scala.collection.immutable.Map<TaskName, Ru
 
     log.info("Got current run Id: {}.", runId);
 
+    log.info("Got isHighLevelApiJob flag: {}.", isHighLevelApiJob);

Review Comment:
   Nit: replace `Got isHighLevelApiJob flag: {}` to something meaningful instead of exposing the field/accessor name.



##########
samza-core/src/main/java/org/apache/samza/config/ApplicationConfig.java:
##########
@@ -46,6 +46,11 @@ public enum ApplicationMode {
     BATCH
   }
 
+  public enum ApplicationApiType {
+    LEGACY,
+    LOW_LEVEL,
+    HIGH_LEVEL
+  }

Review Comment:
   Please introduce this `enum` in samza-api module instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org