You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by rf...@apache.org on 2006/09/27 05:51:02 UTC
svn commit: r450301 - in
/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension:
DOMHelper.java DataBindingExtension.java SimpleTypeMapperExtension.java
XSDDataTypeConverter.java
Author: rfeng
Date: Tue Sep 26 20:51:01 2006
New Revision: 450301
URL: http://svn.apache.org/viewvc?view=rev&rev=450301
Log:
Fix PMD violations
Modified:
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DOMHelper.java
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DataBindingExtension.java
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/SimpleTypeMapperExtension.java
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/XSDDataTypeConverter.java
Modified: incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DOMHelper.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DOMHelper.java?view=diff&rev=450301&r1=450300&r2=450301
==============================================================================
--- incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DOMHelper.java (original)
+++ incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DOMHelper.java Tue Sep 26 20:51:01 2006
@@ -39,14 +39,11 @@
}
public static Document newDocument() throws ParserConfigurationException {
- DocumentBuilder builder = newDocumentBuilder();
- Document document = builder.newDocument();
- return document;
+ return newDocumentBuilder().newDocument();
}
public static DocumentBuilder newDocumentBuilder() throws ParserConfigurationException {
- DocumentBuilder builder = factory.newDocumentBuilder();
- return builder;
+ return factory.newDocumentBuilder();
}
public static QName getQName(Node node) {
@@ -56,8 +53,7 @@
}
// node.getLocalName() will return null if it is created using DOM Level 1 method
// such as createElement()
- QName name = new QName(ns, node.getNodeName());
- return name;
+ return new QName(ns, node.getNodeName());
}
public static Element createElement(Document document, QName name) {
Modified: incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DataBindingExtension.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DataBindingExtension.java?view=diff&rev=450301&r1=450300&r2=450301
==============================================================================
--- incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DataBindingExtension.java (original)
+++ incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/DataBindingExtension.java Tue Sep 26 20:51:01 2006
@@ -70,8 +70,7 @@
public DataType introspect(Class<?> javaType) {
if (baseType.isAssignableFrom(javaType)) {
- DataType<Class> dataType = new DataType<Class>(name, javaType, baseType);
- return dataType;
+ return new DataType<Class>(name, javaType, baseType);
} else {
return null;
}
Modified: incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/SimpleTypeMapperExtension.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/SimpleTypeMapperExtension.java?view=diff&rev=450301&r1=450300&r2=450301
==============================================================================
--- incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/SimpleTypeMapperExtension.java (original)
+++ incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/SimpleTypeMapperExtension.java Tue Sep 26 20:51:01 2006
@@ -358,8 +358,7 @@
} else if (obj instanceof Date) {
return toXMLGregorianCalendar((Date) obj).toXMLFormat();
} else if (obj instanceof XMLGregorianCalendar) {
- XMLGregorianCalendar calendar = (XMLGregorianCalendar) obj;
- return calendar.toXMLFormat();
+ return ((XMLGregorianCalendar) obj).toXMLFormat();
} else if (obj instanceof byte[]) {
if (simpleType.getQName().equals(XSD_BASE64)) {
return printBase64Binary((byte[]) obj);
Modified: incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/XSDDataTypeConverter.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/XSDDataTypeConverter.java?view=diff&rev=450301&r1=450300&r2=450301
==============================================================================
--- incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/XSDDataTypeConverter.java (original)
+++ incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/databinding/extension/XSDDataTypeConverter.java Tue Sep 26 20:51:01 2006
@@ -713,11 +713,11 @@
}
public double parseDouble(String value) {
- if (value.equals("INF")) {
+ if ("INF".equals(value)) {
return Double.POSITIVE_INFINITY;
- } else if (value.equals("-INF")) {
+ } else if ("-INF".equals(value)) {
return Double.NEGATIVE_INFINITY;
- } else if (value.equals("NaN")) {
+ } else if ("NaN".equals(value)) {
return Double.NaN;
} else {
return Double.parseDouble(value);
@@ -733,11 +733,11 @@
}
public float parseFloat(String value) {
- if (value.equals("INF")) {
+ if ("INF".equals(value)) {
return Float.POSITIVE_INFINITY;
- } else if (value.equals("-INF")) {
+ } else if ("-INF".equals(value)) {
return Float.NEGATIVE_INFINITY;
- } else if (value.equals("NaN")) {
+ } else if ("NaN".equals(value)) {
return Float.NaN;
} else {
return Float.parseFloat(value);
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org