You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by "Digy (JIRA)" <ji...@apache.org> on 2011/06/16 18:01:47 UTC

[Lucene.Net] [jira] [Resolved] (LUCENENET-426) Mark BaseFragmentsBuilder methods as virtual

     [ https://issues.apache.org/jira/browse/LUCENENET-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Digy resolved LUCENENET-426.
----------------------------

       Resolution: Fixed
    Fix Version/s: Lucene.Net 2.9.4g
                   Lucene.Net 2.9.4

Thanks Itamar.
Fixed in trunk & 2.9.4g branch.

DIGY

> Mark BaseFragmentsBuilder methods as virtual
> --------------------------------------------
>
>                 Key: LUCENENET-426
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-426
>             Project: Lucene.Net
>          Issue Type: Improvement
>          Components: Lucene.Net Contrib
>    Affects Versions: Lucene.Net 2.9.2, Lucene.Net 2.9.4, Lucene.Net 3.x, Lucene.Net 2.9.4g
>            Reporter: Itamar Syn-Hershko
>            Priority: Minor
>             Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g
>
>         Attachments: fvh.patch
>
>
> Without marking methods in BaseFragmentsBuilder as virtual, it is meaningless to have FragmentsBuilder deriving from a class named "Base", since most of its functionality cannot be overridden. Attached is a patch for marking the important methods virtual.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira