[GitHub] [helix] qqu0127 commented on a diff in pull request #2381: Adding a new metric to report number of partitions with missing top state beyond threshold

["qqu0127 (via GitHub)" <gi...@apache.org>]

qqu0127 commented on code in PR #2381:
URL: https://github.com/apache/helix/pull/2381#discussion_r1115892193


##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java:
##########
@@ -125,6 +128,7 @@ public ResourceMonitor(String clusterName, String resourceName, ObjectName objec
     _numLessMinActiveReplicaPartitions =
         new SimpleDynamicMetric("MissingMinActiveReplicaPartitionGauge", 0L);
     _numNonTopStatePartitions = new SimpleDynamicMetric("MissingTopStatePartitionGauge", 0L);
+    _missingTopStatePartitionsBeyondThresholdGuage = new SimpleDynamicMetric("MissingTopStatePartitionsBeyondThresholdGauge", 0L);

Review Comment:
   Typo? guage -> gauge



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org