You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/17 21:09:12 UTC

[GitHub] [arrow-site] alamb commented on a diff in pull request #256: [MINOR] Improve formatting of json examples + links in nested parquet blogs

alamb commented on code in PR #256:
URL: https://github.com/apache/arrow-site/pull/256#discussion_r997512250


##########
_posts/2022-10-08-arrow-parquet-encoding-part-2.md:
##########
@@ -230,29 +230,29 @@ The Parquet encoding of the example would be:
 
 Closing out support for nested types are *lists*, which contain a variable number of other values. For example, the following four documents each have a (nullable) field `a` containing a list of integers
 
-```json
-{                     <-- First record
-  "a": [1],           <-- top-level field a containing list of integers
+```python
+{                     # <-- First record
+  "a": [1],           # <-- top-level field a containing list of integers
 }
 ```
-```json
-{                     <-- "a" is not provided (is null)
+```python
+{                     # <-- "a" is not provided (is null)
 }
 ```
-```json
-{                     <-- "a" is non-null but empty
+```python
+{                     # <-- "a" is non-null but empty
   "a": []
 }
 ```
-```json
+```python
 {
-  "a": [null, 2],     <-- "a" has a null and non-null elements
+  "a": [null, 2],     # <-- "a" has a null and non-null elements
 }
 ```
 
 Documents of this format could be stored in this Arrow schema
 
-```text
+```python

Review Comment:
   I actually thought they look slightly better when formatted as "python" (as there is some visual difference):
   
   <img width="792" alt="Screen Shot 2022-10-17 at 5 08 12 PM" src="https://user-images.githubusercontent.com/490673/196283777-1e449987-4b63-442b-82c0-2548147cbe64.png">
   
   I can revert it you prefer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org