You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/22 12:58:16 UTC

[GitHub] [incubator-kvrocks] git-hulk opened a new issue, #647: Track failed frequently integration test cases

git-hulk opened a new issue, #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   As mentioned in https://github.com/apache/incubator-kvrocks/pull/646#issuecomment-1162660044, some integration test cases failed frequently
   which may frustrate and confuse contributors, so I think we can find out
   and disable them from old runs.
   
   
   ### Solution
   
   - [ ] Find out all failure frequently cases from old runs
   - [ ] Disable them first, then fix them one by one
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1163070663

   You may give a report (sheet) for flaky tests, sorting out by categorizes. For example, tcl tests or unit tests.
   
   It should be helpful for anyone who tries to contribute to stabilize tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1165296241

   @git-hulk I've created them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1288019508

   Closed as all subtasks done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1163086261

   
   
   
   > You may give a report (sheet) for flaky tests, sorting out by categorizes. For example, tcl tests or unit tests.
   > 
   > It should be helpful for anyone who tries to contribute to stabilize tests.
   
   Good point, all cases are from tcl tests. I will find them all recently and group them together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1165290586

   > @git-hulk yes. We can create subtasks for them. Basically we create issue if someone volunteer to investigate (otherwise we create dangling issues), and it happens I'll give a look at these cases :)
   
   OK, will create issues later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun closed issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #647: Track failed frequently integration test cases
URL: https://github.com/apache/incubator-kvrocks/issues/647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1288048344

   👍 Really great work, it's really to debug the flaky tests now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1165240775

   @tisonkun I found most failures were caused by four tcl test cases,should we create issue for each one to track them?
   <img width="736" alt="image" src="https://user-images.githubusercontent.com/4987594/175474994-58b7cb7a-d89c-48f3-bae8-72e024e14ba8.png">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1165296520

   Many thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1166530598

   @git-hulk all previous subtasks resolved. However, there is a new failure #676 detected :/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1169031156

   ```
   *** [err]: Set instance A as slave of B in tests/integration/replication.tcl
   Expected '1' to be equal to '0' (context: type source line 41 file /Users/runner/work/incubator-kvrocks/incubator-kvrocks/tests/tcl/tests/integration/replication.tcl cmd {assert_equal {1} [s -1 loading]} proc ::test)
   *** [err]: requests on cluster are ok in tests/integration/cluster.tcl
   Expected '16383' to be equal to '' (context: type source line 257 file /Users/runner/work/incubator-kvrocks/incubator-kvrocks/tests/tcl/tests/integration/cluster.tcl cmd {assert_equal "16383" [$r3 get $slot_16383_key]} proc ::test)
   ```
   in https://github.com/apache/incubator-kvrocks/runs/7096118532?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1165280591

   @git-hulk yes. We can create subtasks for them. Basically we create issue if someone volunteer to investigate, and it happens I'll give a look at these cases :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #647: Track failed frequently integration test cases

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #647:
URL: https://github.com/apache/incubator-kvrocks/issues/647#issuecomment-1166550791

   > @git-hulk all previous subtasks resolved. However, there is a new failure #676 detected :/
   
   Got it, thanks @tisonkun. I will follow up and try to figure out the root cause.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org