You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/21 13:42:59 UTC
[GitHub] [flink] klion26 commented on a change in pull request #8229: FLINK-12273[The default value of CheckpointRetentionPolicy should be …
klion26 commented on a change in pull request #8229: FLINK-12273[The default value of CheckpointRetentionPolicy should be …
URL: https://github.com/apache/flink/pull/8229#discussion_r277168751
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -627,7 +627,7 @@ private void configureCheckpointing() {
CheckpointRetentionPolicy.RETAIN_ON_FAILURE :
CheckpointRetentionPolicy.RETAIN_ON_CANCELLATION;
} else {
- retentionAfterTermination = CheckpointRetentionPolicy.NEVER_RETAIN_AFTER_TERMINATION;
+ retentionAfterTermination = CheckpointRetentionPolicy.RETAIN_ON_FAILURE;
Review comment:
Why do you want to change the default value here, instead of set an external checkpoint cleanup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services