You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metamodel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/10 04:11:04 UTC

[jira] [Commented] (METAMODEL-1139) Support java.util.function types (over our own functional types)

    [ https://issues.apache.org/jira/browse/METAMODEL-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004014#comment-16004014 ] 

ASF GitHub Bot commented on METAMODEL-1139:
-------------------------------------------

GitHub user kaspersorensen opened a pull request:

    https://github.com/apache/metamodel/pull/144

    METAMODEL-1139: Use Java 8 functions instead of our own Ref, Action and Func types

    This time the same as #142  but now with an official issue number (https://issues.apache.org/jira/browse/METAMODEL-1139) and suggestion to merge to the `5.x` branch

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kaspersorensen/metamodel java-8-functions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit f015665d88ae5066e8657575bb01baa7af0a0f13
Author: Kasper Sørensen <i....@gmail.com>
Date:   2017-04-29T23:05:07Z

    Deprecated Ref, Func and Predicate in favor of java.util.function
    
    "Ref" to be replaced by Supplier.
    "Func" to be replaced by Function.
    "Predicate" to be replaced by Predicate.
    "Action" to extend Consumer (allowing for throwing checked exceptions).
    "UncheckedFunc to extend Function.
    
    Also added `@SuppressWarning` on method that the Java 8 compiler is
    emitting warnings for while the code being alright.

commit bf943d5bcfe916573c43d8323713e5e864c24c92
Author: Kasper Sørensen <i....@gmail.com>
Date:   2017-05-02T13:03:53Z

    Removed strange comment-line as pointed out by Tomasz G.

commit 400fc73165e87a9930a736c229e366232935e8ad
Author: Kasper Sørensen <i....@gmail.com>
Date:   2017-05-02T23:02:05Z

    Removed Java 7 build from Travis CI config

commit e5381fd47763968bce63057627e31de4e1f7b01e
Author: Kasper Sørensen <i....@gmail.com>
Date:   2017-05-10T03:56:44Z

    Merge branch '5.x' into java-8-functions
    
    # Conflicts:
    #	core/src/main/java/org/apache/metamodel/MetaModelHelper.java

commit 94e72019b2e710ea927748c67aa5083928cc5c77
Author: Kasper Sørensen <i....@gmail.com>
Date:   2017-05-10T04:03:13Z

    METAMODEL-1139: Added UpdateSummary to dynamo DB data context

----


> Support java.util.function types (over our own functional types)
> ----------------------------------------------------------------
>
>                 Key: METAMODEL-1139
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-1139
>             Project: Apache MetaModel
>          Issue Type: Improvement
>            Reporter: Kasper Sørensen
>            Assignee: Kasper Sørensen
>            Priority: Minor
>
> We have functional types like Ref, Action, Func. As we are anyways retiring Java 7 support in the 5.x branch, we should also lean towards (re)using the Java 8 functional types like Supplier, Consumer, Function.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)